Build fails when certain modules loaded into layer

[dante]

Trying to run a build with the profile:

dependencies = {
	layers: [
		{
			name: "../dijit/ui.js",
			resourceName:"dijit.ui",
			dependencies: [
				"dijit.form.Slider"
			]
		}
	],

	prefixes: [
		[ "dijit", "../dijit" ],
	]
};

throws an error:

release:  Building dojo.js and layer files
error loading uri: ./../../release/dojo/dijit/form/Slider.js, exception: TypeError: Cannot call method "split" of undefined

Building with a slightly different profile works (replacing the single 'dijit.slider' ref with the expansion of the rollup contents into modules):

dependencies = {
	layers: [
		{
			name: "../dijit/ui.js",
			resourceName:"dijit.ui",
			dependencies: [
				"dijit.form.HorizontalSlider",
				"dijit.form.VerticalSlider",
				"dijit.form.HorizontalRule",
				"dijit.form.VerticalRule",
				"dijit.form.HorizontalRuleLabels",
				"dijit.form.VerticalRuleLabels"
			]
		}
	],

	prefixes: [
		[ "dijit", "../dijit" ],
	]
};

not sure if this is a build issue, a stubs issue (part of 1:1 mapping is why Slider.js is there)

[dante]

ugh. you know what this is:

dojo.deprecated("Do dojo.require() HorizontalSlider, VerticalRule, etc, rather than of dijit.form.Slider itself", "", "2.0");

the build matches the dojo.require in the deprecated call and tries to load it into the layer, but can't split by '.' on an undefined match.

is "Use require()" unclear in the deprecated call?

also need to peek in other stubs like this generated talking about dojo.require changes.

[James Burke]

Using "Do dojo.require" without the parentheses should also be safe.

[dante]

this only appeared in the one place. Note: there are a LOT of places that reference dojo.require() inside of comment blocks, but that doesn't seem to affect the build at all.

[James Burke]

Comments are stripped before looking for dojo.require calls, but not string values.