Opened 12 years ago
Closed 10 years ago
#8446 closed enhancement (wontfix)
Enhance dojo.create().
Reported by: | Eugene Lazutkin | Owned by: | dante |
---|---|---|---|
Priority: | high | Milestone: | 1.3 |
Component: | HTML | Version: | 1.2.3 |
Keywords: | Cc: | James Burke, dante | |
Blocked By: | Blocking: |
Description (last modified by )
Enhance dojo.create() with dojo._toDom() functionality. See #7890 for more details.
Change History (17)
comment:1 Changed 12 years ago by
Status: | new → assigned |
---|
comment:2 Changed 12 years ago by
comment:3 Changed 12 years ago by
comment:4 Changed 12 years ago by
The current code can deal with missing attrs, and it can use refNode's document to create elements in the correct document.
comment:5 Changed 12 years ago by
comment:7 Changed 12 years ago by
comment:8 Changed 12 years ago by
Description: | modified (diff) |
---|
dojo.create() enhancements are tracked in #8446.
comment:10 Changed 12 years ago by
It was decided to roll back dojo._toDom()
call, and make attrs
mandatory to simplify the code.
comment:11 Changed 12 years ago by
comment:13 Changed 12 years ago by
Owner: | changed from Eugene Lazutkin to dante |
---|---|
Status: | assigned → new |
The documentation is here: http://docs.dojocampus.org/dojo/create
Reassigning this ticket to Pete for review, and closing, if everything is fine.
comment:14 Changed 12 years ago by
Priority: | normal → high |
---|---|
Status: | new → assigned |
this is 99.9% complete, just need to verify docs. accepting so it doesn't get lost with other place/create tickets.
comment:15 Changed 12 years ago by
Resolution: | → fixed |
---|---|
Status: | assigned → closed |
docs are accurate. dom guide is on me. not sure i'm 100% on create not accepting complex markup, but understand the complications.
comment:16 Changed 10 years ago by
Resolution: | fixed |
---|---|
Status: | closed → reopened |
I'd say this should be marked as wontfix since we ended up not supporting this syntax in dojo.create(), but rather in dojo.place().
comment:17 Changed 10 years ago by
Resolution: | → wontfix |
---|---|
Status: | reopened → closed |
I've noticed a bug in dojo.create() --- the "attrs" argument is declared optional, but there is no code to cover the missing attrs.