Opened 11 years ago

Closed 8 years ago

#8446 closed enhancement (wontfix)

Enhance dojo.create().

Reported by: Eugene Lazutkin Owned by: dante
Priority: high Milestone: 1.3
Component: HTML Version: 1.2.3
Keywords: Cc: James Burke, dante
Blocked By: Blocking:

Description (last modified by Eugene Lazutkin)

Enhance dojo.create() with dojo._toDom() functionality. See #7890 for more details.

Change History (17)

comment:1 Changed 11 years ago by Eugene Lazutkin

Status: newassigned

I've noticed a bug in dojo.create() --- the "attrs" argument is declared optional, but there is no code to cover the missing attrs.

comment:2 Changed 11 years ago by Eugene Lazutkin

(In [16378]) Adding dojo._toDom() functionality top dojo.create() with unit tests, !strict, refs #8446.

comment:3 Changed 11 years ago by Eugene Lazutkin

(In [16379]) Adding the handling of missing attrs with a unit test, !strict, refs #8446.

comment:4 Changed 11 years ago by Eugene Lazutkin

The current code can deal with missing attrs, and it can use refNode's document to create elements in the correct document.

comment:5 Changed 11 years ago by Eugene Lazutkin

(In [16380]) Removing unnecessary notes from the inlined documentation, !strict, refs #8446.

comment:6 Changed 11 years ago by Eugene Lazutkin

(In [16381]) More inlined docs changes, !strict, refs #8446.

comment:7 Changed 11 years ago by Eugene Lazutkin

(In [16382]) refNode can be a string too --- making sure to count it in when attrs is missing, !strict, refs #8446.

comment:8 Changed 11 years ago by Eugene Lazutkin

Description: modified (diff)

dojo.create() enhancements are tracked in #8446.

comment:9 Changed 11 years ago by Eugene Lazutkin

Oops. dojo.place() enhancements are tracked in #8380.

comment:10 Changed 11 years ago by Eugene Lazutkin

It was decided to roll back dojo._toDom() call, and make attrs mandatory to simplify the code.

comment:11 Changed 11 years ago by Eugene Lazutkin

(In [16440]) Rolling back some changes to dojo.create(), updating docs and unit tests, !strict, refs #8446.

comment:12 Changed 11 years ago by Eugene Lazutkin

Now it is ready to be documented.

comment:13 Changed 11 years ago by Eugene Lazutkin

Owner: changed from Eugene Lazutkin to dante
Status: assignednew

The documentation is here: http://docs.dojocampus.org/dojo/create

Reassigning this ticket to Pete for review, and closing, if everything is fine.

comment:14 Changed 11 years ago by dante

Priority: normalhigh
Status: newassigned

this is 99.9% complete, just need to verify docs. accepting so it doesn't get lost with other place/create tickets.

comment:15 Changed 11 years ago by dante

Resolution: fixed
Status: assignedclosed

docs are accurate. dom guide is on me. not sure i'm 100% on create not accepting complex markup, but understand the complications.

comment:16 Changed 8 years ago by bill

Resolution: fixed
Status: closedreopened

I'd say this should be marked as wontfix since we ended up not supporting this syntax in dojo.create(), but rather in dojo.place().

comment:17 Changed 8 years ago by bill

Resolution: wontfix
Status: reopenedclosed
Note: See TracTickets for help on using tickets.