Opened 12 years ago

Closed 12 years ago

Last modified 12 years ago

#8428 closed defect (wontfix)

Need to autoupdate dojo.version in release script

Reported by: Adam Peller Owned by: dante
Priority: high Milestone: 1.4
Component: BuildTools Version: 1.2.3
Keywords: Cc:
Blocked By: Blocking:

Description (last modified by Adam Peller)

dojo.version major, minor and patch should be updated by the release script.

Change History (9)

comment:1 Changed 12 years ago by Adam Peller

Description: modified (diff)

It hasn't been updated since 1.1.0 :-O

comment:2 Changed 12 years ago by Adam Peller

(In [16348]) Update minor rev in lieu of script. Refs #8428. Inline rev, remove conditional since it's always got to be there.

comment:3 Changed 12 years ago by Adam Peller

(In [16349]) remove hostenv comment inserted in [16348] Refs #8428

comment:4 Changed 12 years ago by Adam Peller

(In [16357]) Undo inlining of rev. Distributed SCM like git and bzr provide alternate access to our svn and will not substitute keywords. Refs #8428

comment:5 Changed 12 years ago by dante

Milestone: tbd1.4

so this is actually not straightforward. We use build_release (iirc) for branch as well, and the current changeVersion function works to change all the revision info about dojo.version ... but it is applied to the tag (and committed). If it were applied to "whatever the next version would be" we'd have to differentiate between branch and trunk, and otherwise complicate the operation.

know what needs to happen, just no simple solution comes to mind. will update manually for 1.3 -> 1.4 while solution found.

comment:6 Changed 12 years ago by dante

Resolution: wontfix
Status: newclosed

i'm happy manually updating the tag after a major. for 1.3->1.4 it acted as a sort of indication trunk was open again after release. please reopen if you feel inclined to fix this to be automated.

comment:7 Changed 12 years ago by Adam Peller

I can't believe anyone else noticed. I think it should be automated. Trunk should be open right away, since we can always create a branch off any revision. If you wish to shut down development, there should probably be a way to lock the trunk.

comment:8 Changed 12 years ago by dante

I'm just saying I don't want to spend any cycles on making this automated, as it is a very low priority for me. we don't release that often.

comment:9 Changed 12 years ago by Adam Peller

fair enough.

Note: See TracTickets for help on using tickets.