Form: multiple TextBoxes with the same 'name' attribute are not returned as array

[coldfire22x]

When creating multiple TextBox? widgets with the same "name" attribute within the same dijit.form.Form, form.attr("value") does not return all of those values as an array. See attached.

[Adam Peller]

don't names within a form have to be unique?

[bill]

Hmm, that's odd, it works for checkboxes, see ​http://download.dojotoolkit.org/release-1.2.1/dojo-release-1.2.1/dijit/tests/form/Form.html.

Must be a problem either with the name ("value[]" rather than just "value"), or with TextBox rather than CheckBox. I'll take a look.

[bill]

OK, I looked over the code of Form.js. Currently only checkboxes with the same name are handled. Dates back to [9766].

The issue doesn't have anything to do w/the special characters in the name.

[Douglas Hays]

How will _setValueAttr work with a TextBox? value array?

[bill]

Doug, I think you were working on this, right?

_setValueAttr() with an array should assign the list of values sequentially, so that the first array element gets assigned to the first TextBox and so forth.

Actually, there's code for that already, not sure why it isn't working:

// otherwise, values is a list of values to be assigned sequentially to each widget
dojo.forEach(widgets, function(w, i){
        w.attr('value', values[i]);
});                                     

[Douglas Hays]

patch file to create an array for duplicate named widgets

[bill]

The patch looks good for Form.getValue()... is setValue() working correctly too? There should be a test for that.

As I said on IM, I think lines 239-242 could be simplified to dojo.setObject(name, [prev, value], obj);.

The other thing this made me think about was how to handle single checkboxes. I'd like to change the current behavior but I think it needs to wait until 2.0, so I filed #9962.

[Douglas Hays]

(In [20239]) Fixes #8426. On Form value get, changes multiple form values with the same name attribute into an array. Set already worked with array values. Added test to Form.html.

[bill]

On chrome 3 I'm getting failures (in the Form.html unit test) that the value is reported as duplicate: ["three"] instead of duplicate: ["first", "second", "third"]. It's working on FF (although I'm seeing another problem with Editor's value being blank, probably a race condition about the iframe initialization).

[Douglas Hays]

(In [20286]) Fixes #8426. Slowed down test setup to give Editor a chance to render, but unrelated to this ticket. No test errors reported on FF 3.5 or Chrome 3.0 on Windows.