exception thrown when entering invalid value in an editable cell of a DataGrid

[goriol]

Context: A DataGrid? is created with one of its cells marked as editable. As that cell should only contain integers, the grid structure defines the field this way:

    ...
    {
      field: qty
      editable: true,
      type: dojox.grid.cells._Widget,
      widgetClass: dijit.form.NumberTextBox,
      constraint: { places: 0 }
    },
    ...

Scenario:

• I double-click on the editable cell to change its value
• I type an invalid value (for example "1.5", as I set up "places: 0" as a constraint)
• I get a tooltip saying the value is not valid (this is the expected behavior).
• I discard the message and press Enter to submit the value
• An exception is thrown:

  [Exception... "'Error: assertion failed in ItemFileWriteStore' when calling method: [nsIDOMEventListener::handleEvent]" 
    nsresult: "0x8057001c (NS_ERROR_XPC_JS_THREW_JS_OBJECT)" location: "" data: no]
  

I was able to trace back this error up to ItemFileWriteStore._setValueOrValues() (which is called by the setValue() function). The exception is thrown at this line:

this._assert(typeof newValueOrValues !== "undefined");

I don't understand why this function is executed. As the value is invalid, the setValue() function should never be called, right?

[goriol]

test page

[Bryan Forbes]

The change for this will be very invasive because it will require figuring out a way to have validating widgets cancel an apply. Moving to 1.4.

[Nathan Toone]

Moving non-regressions to 1.5

[bill]

1.5 is released, moving remaining tickets to 1.6

[bill]

(sadly) punting seemingly abandoned ticket and meta tickets to future

[evan]

(In [25107]) Fixes #8374 not apply changes when there is validation error in the editing widget

[evan]

(In [25235]) Refs #8374 backport fix to 1.6 branch

[evan]

(In [25237]) Refs #8374 backport fix to 1.5 branch