Dialog: add an option so that it can't be closed by "normal means"

[liucougar]

introduce closable option on dijit.Dialog, which is by default true.

If it is set to false, the close button on the titlebar will be hidden, and escape key won't close this dialog.

onExecute/onCancel won't hide the dialog automatically if closable=false

developer has to make sure that, if closable=false is used, some controls (such as buttons) are available in the content of the dialog, so that the end user can close it if some criteria is met

[dante]

fwiw, this is already possible with dojox.widget.Dialog modal=true

it simply intercepts a connect to dijit._underlay in show() and listens for esc calling dojo.stopEvent(e) when found.

[bill]

Almost, except that (as Cougar pointed out to me) the [x] icon still shows up.

BTW, the term ​modal for that parameter is incorrect, as all Dialogs are modal. Maybe "closable" is a better name, although that too is confusing given that the user can still presumably close the dialog somehow, by clicking on a button in the dialog.

[dante]

@bill - I agree the term 'modal' is slightly confusing. Honestly, I thought dojox.Dialog already had a closable param that disabled the X showing up onmouseenter. One line fix to change that. But I still would like to see this behavior in dijit.Dialog officially.

[bill]

FYI, this is achievable via CSS:

#myDialog .closeButtonNode {
   display: none;
}

Oh, except that doesn't handle using ESC to close the Dialog.

See also #9670, which asks for a similar feature and discusses disabling the ESC key.

[bill]

#9670 is a duplicate of this ticket.

[bill]

In [30966]:

Add Dialog.closable property, to hide the [x] icon and disable ESC as a way to close the dialog. Also removing aria-describedby property, as this is handled implicitly by _WidgetBase. Fixes #8345 !strict.