Opened 10 years ago

Closed 10 years ago

#8341 closed defect (fixed)

[patch][cla] DataGrid triggering inappropriate fetch

Reported by: Kris Zyp Owned by: Bryan Forbes
Priority: high Milestone: 1.3
Component: DojoX Grid Version: 1.2.3
Keywords: Cc:
Blocked By: Blocking:

Description

When a new item is added to a store that the grid is displaying, and the grid is currently shoing no items (or presumably whenever the new item falls on the page boundary), the grid will induce a another fetch to the same page that requested previously when the grid's view of the data started.

Attachments (2)

DataGridFetchFix.diff (718 bytes) - added by Kris Zyp 10 years ago.
Probably not the best way, but this seems to fix the problem when the grid is empty
data_grid_empty_test.patch (599 bytes) - added by Kris Zyp 10 years ago.
Patch for the empty data grid test that checks to make sure a fetch was not triggered

Download all attachments as: .zip

Change History (7)

Changed 10 years ago by Kris Zyp

Attachment: DataGridFetchFix.diff added

Probably not the best way, but this seems to fix the problem when the grid is empty

comment:1 Changed 10 years ago by Bryan Forbes

Milestone: tbdfuture

comment:2 Changed 10 years ago by Kris Zyp

Is there a problem with this patch? Is there a reason we can't apply it for 1.3? Why did it get moved to future? I can apply if it looks OK.

comment:3 Changed 10 years ago by Bryan Forbes

Milestone: future1.3
Summary: DataGrid triggering inappropriate fetch[patch][cla] DataGrid triggering inappropriate fetch

Sorry about that. I got overzealous trying to triage.

Changed 10 years ago by Kris Zyp

Attachment: data_grid_empty_test.patch added

Patch for the empty data grid test that checks to make sure a fetch was not triggered

comment:4 Changed 10 years ago by Kris Zyp

OK, I added a patch for testing this issue.

comment:5 Changed 10 years ago by Bryan Forbes

Resolution: fixed
Status: newclosed

(In [16509]) * Fix DataGrid? triggering a fetch when the grid is showing no items and you add a new items (fixes #8341 !strict).

Note: See TracTickets for help on using tickets.