#834 closed enhancement (fixed)
Update Checkbox.js to 0.3.0
Reported by: | Owned by: | anonymous | |
---|---|---|---|
Priority: | high | Milestone: | |
Component: | Website | Version: | 0.3 |
Keywords: | Checkbox defineWidget 0.3.0 | Cc: | |
Blocked By: | Blocking: |
Description
Redid using defineWidget, removed
"dojo.lang.extend(dojo.widget.Checkbox, {
widgetType: "Checkbox"
}); " as well since that can be done in the widgets defineWidget call directly... Nightly Test seems to work fine with this patch applied on my local system
Attachments (1)
Change History (5)
Changed 15 years ago by
Attachment: | Checkbox.diff added |
---|
comment:1 Changed 15 years ago by
In my haste to do this, I forgot there was a html/checkbox.js as well, this is for src/widget/
And before I can update html/Checkbox.js I need to ask a few questions regarding why its originally done using lang.extend instead of just a regular setup like most other widgets used to build the widget object.
comment:2 Changed 15 years ago by
Milestone: | → 0.3.1 |
---|
Hi Karl,
This
this.fillInTemplate = ...
way of writing widgets was deprecated in favor of using lang.extends. lang.extends is actually newer.
But the lang.extends was itself deprecated. defineWidget() is the newest way.
Anyway, I updated checkbox to use defineWidget(). BTW, if there is both a file in widget/html and widget/, the file in widget should use anything other than dojo.declare, and it shouldn't extend dojo.widget.Widget either. This was a mistake in the old version of CheckBox?.
comment:3 Changed 15 years ago by
Resolution: | → fixed |
---|---|
Status: | new → closed |
patch from 0.3.0 to 0.3.0 using defineWidget