Opened 11 years ago

Closed 11 years ago

Last modified 8 years ago

#8332 closed defect (fixed)

[regression] Spinner: arrows broken in nightlies

Reported by: Adam Peller Owned by: Adam Peller
Priority: high Milestone: 1.3
Component: Dijit - Form Version: 1.2.3
Keywords: Cc:
Blocked By: Blocking:

Description (last modified by Adam Peller)

I was reading this http://www.dojotoolkit.org/forum/dijit-dijit-0-9/dijit-support/number-spinner

and I'm not sure it has anything to do with the problems reported there, but I tried the nightlies (trunk) on FF3/Mac and the spinner looks broken. The 1.2.3 release looks fine.

snapshot of test_Spinner.html from Dec 29 nightly

Attachments (1)

Picture 1.png (30.7 KB) - added by Adam Peller 11 years ago.
snapshot of test_Spinner.html from Dec 29 nightly

Download all attachments as: .zip

Change History (9)

Changed 11 years ago by Adam Peller

Attachment: Picture 1.png added

snapshot of test_Spinner.html from Dec 29 nightly

comment:1 Changed 11 years ago by Adam Peller

Description: modified (diff)

comment:2 Changed 11 years ago by Adam Peller

Description: modified (diff)

comment:3 Changed 11 years ago by bill

Owner: changed from Douglas Hays to Adam Peller

This is actually from [16094].

comment:4 Changed 11 years ago by bill

Milestone: tbd1.3
Summary: Spinner arrows broken in nightlies[regression] Spinner: arrows broken in nightlies

comment:5 Changed 11 years ago by Adam Peller

Resolution: fixed
Status: newclosed

(In [16216]) Undo regression from [16094]. Fixes #8332, Refs #8287

comment:6 Changed 11 years ago by Adam Peller

My bad. I think it's the second time I've broken this. Tools show the 'none' value as invalid CSS. Bill points out that we might be able to remove these lines entirely. I tried it and it seems to work. Doug - do you think this is okay?

comment:7 Changed 11 years ago by Douglas Hays

I think they should be changed to auto from none, but should remain in the file to ensure proper rendering.

comment:8 Changed 8 years ago by bill

Component: DijitDijit - Form
Note: See TracTickets for help on using tickets.