Opened 11 years ago

Closed 11 years ago

#8319 closed defect (fixed)

dojo.Color's are mixed into themselves

Reported by: dante Owned by: dante
Priority: high Milestone: 1.3
Component: Core Version: 1.2.3
Keywords: Cc: alex, Adam Peller, James Burke
Blocked By: Blocking:

Description

dojo.Color.named is defined in _base/Color.js, then later in dojo/color.js extended like:

dojo.Color.named = dojo.mixin({ ... }, dojo.Color.named);

It is arguably a breaking change to reduce to:

dojo.mixin(dojo.Color.named, { ... });

but only under the premise you are mixing named colors into dojo.Color.named before loading color.js and expecting them to override dojo's definition of those colors. it is my understanding the list in color.js is the full/accurate css color map, so no additional mixing should be necessary.

does this break anyone/thing? it shouldn't.

Change History (1)

comment:1 Changed 11 years ago by dante

Resolution: fixed
Status: newclosed

fixed in [16156] (trac is un-sync-d atm)

Note: See TracTickets for help on using tickets.