Opened 10 years ago
Closed 3 years ago
#8304 closed task (patchwelcome)
consider removing this.targetAnchor
| Reported by: | bill | Owned by: | Eugene Lazutkin |
|---|---|---|---|
| Priority: | high | Milestone: | 1.13 |
| Component: | DnD | Version: | 1.2.3 |
| Keywords: | Cc: | ||
| Blocked By: | Blocking: |
Description
Looks like this.targetAnchor and this.current are always the same thing. Or rather, they are the same during a drag operation, and when you aren't dragging then this.targetAnchor is null.
Consider removing this.targetAnchor and just using this.current. I'm looking at doing that for Tree now.
Change History (3)
comment:1 Changed 10 years ago by
comment:3 Changed 3 years ago by
| Milestone: | future → 1.12 |
|---|---|
| Resolution: | → patchwelcome |
| Status: | new → closed |
Given that no one has shown interest in creating a patch in the past 5+ years, I'm closing this as patchwelcome.
Note: See
TracTickets for help on using
tickets.
I noticed this in the Tree DnD code but it applies to the general DnD code as well.
On more research, It might be complicated to remove. I think Container keeps this.current up to date (based on mouse events), and Source (maybe) is using this.targetAnchor to remember the previous target, so that it can remove the dndItemOver class etc. from that item.