Opened 10 years ago

Closed 9 years ago

Last modified 8 years ago

#8299 closed defect (fixed)

ComboBox / FilteringSelect: setting a padding for input[type="text"] breaks layout

Reported by: thekryz Owned by:
Priority: high Milestone: 1.5
Component: Dijit - Form Version: 1.2.3
Keywords: ComboBox FilteringSelect Cc:
Blocked By: Blocking:

Description

When you define eg.

input[type="text"]{padding:2px;}

for your form styles (I did this to have a little more space in my non-Dojo text input fields), it breaks the style of ComboBox? and FilteringSelect? (see image): The Button on the right side and its left border are not tall enough.

Attachments (1)

comboboxtest2.html (1.3 KB) - added by thekryz 10 years ago.
Minimal Test Case

Download all attachments as: .zip

Change History (9)

Changed 10 years ago by thekryz

Attachment: comboboxtest2.html added

Minimal Test Case

comment:1 Changed 10 years ago by bill

Milestone: tbd1.3

Ah probably lots of cases like this, probably just need some dijitReset in the classes on the nodes in the template (ComboBox.html)

comment:2 Changed 10 years ago by bill

... unless maybe the rule above has higher precedence than a simple class="dijitReset".

comment:3 Changed 10 years ago by bill

Actually I retract my comment above. What are you trying to achieve? Is the issue that the

input[type="text"]{padding:2px;}

rule is affecting the ComboBox and you don't want it to be affected, or is the issue that you are *trying* to adjust the padding of the combobox?

Trying to adjust the height of the input w/out adjusting the height of the arrow won't work.

comment:4 in reply to:  3 Changed 10 years ago by thekryz

Replying to bill:

What are you trying to achieve? Is the issue that the

input[type="text"]{padding:2px;}

rule is affecting the ComboBox and you don't want it to be affected, or is the issue that you are *trying* to adjust the padding of the combobox?

Trying to adjust the height of the input w/out adjusting the height of the arrow won't work.

I want to adjust the height of the input because of a styleguide. So I thought I could probably do this by simply adjusting the padding. I would have expected the arrow button on the right to grow automatically...

comment:5 Changed 10 years ago by bill

Yup, would be nice if it worked that way, and it would work that way if we implemented it with a table, but we aren't doing that for performance reasons, and maybe also to avoid browser bugs. Not sure. Still, it's worth considering.

comment:6 Changed 10 years ago by bill

Milestone: 1.3future

comment:7 Changed 9 years ago by haysmark

Milestone: future1.5
Resolution: fixed
Status: newclosed

Fixed in [22060] as part of the template redo.

comment:8 Changed 8 years ago by bill

Component: DijitDijit - Form
Note: See TracTickets for help on using tickets.