ComboBox / FilteringSelect: setting a padding for input[type="text"] breaks layout

[thekryz]

When you define eg.

input[type="text"]{padding:2px;}

for your form styles (I did this to have a little more space in my non-Dojo text input fields), it breaks the style of ComboBox? and FilteringSelect? (see image): The Button on the right side and its left border are not tall enough.

[thekryz]

Minimal Test Case

[bill]

Ah probably lots of cases like this, probably just need some dijitReset in the classes on the nodes in the template (ComboBox.html)

[bill]

... unless maybe the rule above has higher precedence than a simple class="dijitReset".

[bill]

Actually I retract my comment above. What are you trying to achieve? Is the issue that the

input[type="text"]{padding:2px;}

rule is affecting the ComboBox and you don't want it to be affected, or is the issue that you are *trying* to adjust the padding of the combobox?

Trying to adjust the height of the input w/out adjusting the height of the arrow won't work.

[thekryz]

Replying to bill:

What are you trying to achieve? Is the issue that the

input[type="text"]{padding:2px;}

rule is affecting the ComboBox and you don't want it to be affected, or is the issue that you are *trying* to adjust the padding of the combobox?

Trying to adjust the height of the input w/out adjusting the height of the arrow won't work.

I want to adjust the height of the input because of a styleguide. So I thought I could probably do this by simply adjusting the padding. I would have expected the arrow button on the right to grow automatically...

[bill]

Yup, would be nice if it worked that way, and it would work that way if we implemented it with a table, but we aren't doing that for performance reasons, and maybe also to avoid browser bugs. Not sure. Still, it's worth considering.

[haysmark]

Fixed in [22060] as part of the template redo.