Opened 11 years ago

Closed 11 years ago

#8296 closed defect (fixed)

[patch] [cla] MultiSelect: add label elements into multiSelect test file

Reported by: Becky Gibson Owned by: Joseph Scheuhammer
Priority: high Milestone: 1.3
Component: Accessibility Version: 1.2.3
Keywords: Cc: Adam Peller
Blocked By: Blocking:

Description

In order for dijit/test/form/test_MultiSelect.html to be accessible it needs <label> elements added to the test cases.

Attachments (2)

8296.patch (2.0 KB) - added by Joseph Scheuhammer 11 years ago.
8296a.patch (2.2 KB) - added by Joseph Scheuhammer 11 years ago.

Download all attachments as: .zip

Change History (7)

comment:1 Changed 11 years ago by Becky Gibson

Owner: changed from Becky Gibson to Joseph Scheuhammer

comment:2 Changed 11 years ago by Joseph Scheuhammer

Cc: Adam Peller added

Attaching patch, "8296.patch", that might address this. I'm not sure what needs labelling -- I added <label> elements for all the <select> elements.

Note that this required CSS modifications in order to achieve a reasonable layout for the first pair of <select>'s, their labels, and the transfer buttons between the select lists.

Changed 11 years ago by Joseph Scheuhammer

Attachment: 8296.patch added

comment:3 Changed 11 years ago by Adam Peller

Clown -- I'm not knowledgable in these areas, but do you have an AT you can test on to make sure each field is announced?

comment:4 in reply to:  3 Changed 11 years ago by Joseph Scheuhammer

Summary: MultiSelect: add label elements into multiSelect test file[patch] [cla] MultiSelect: add label elements into multiSelect test file

Replying to peller:

Clown -- I'm not knowledgable in these areas, but do you have an AT you can test on to make sure each field is announced?

Peller, I tested with IE8RC1/FF3 and JAWS10 (WinXP). Looks (sounds) good to me, but Becky should probably give it quick look.

I also checked via !AccEvent32 to see what ARIA information was published by both browsers. The added <label>s are having the proper effect, but I made other tweaks, and so am uploading "8296a.patch":

  • added 'aria-label' property for the "<" and ">" buttons. No effect but I think that's because aria-label is still relatively new.
  • added 'role="presentation"' for the divs that are used to layout the top two lists.

Changed 11 years ago by Joseph Scheuhammer

Attachment: 8296a.patch added

comment:5 Changed 11 years ago by Becky Gibson

Resolution: fixed
Status: newclosed

(In [16356]) fixes #8296 commit for clown (ccla on file). Add instructions to file as well as label elements for the select elements to make accessible to a screen reader user. Note that I modified the patch to use the title attribute on button rather than aria-label since aria-label is not well supported, yet.

Note: See TracTickets for help on using tickets.