Opened 10 years ago

Closed 10 years ago

Last modified 10 years ago

#8271 closed defect (wontfix)

[meta] provide buildExclude option for deprecated methods

Reported by: dante Owned by: dante
Priority: high Milestone: future
Component: General Version: 1.2.3
Keywords: Cc:
Blocked By: Blocking:

Description

There are a lot of deprecated functions in the 1.x code base. Rather than prematurely branching for 2.0, it would be nice to be able to create a build omitting the deprecated functionality via a buildExlude and custom kwArg. So in the profile one would add

deprecated:"off"

and in the code, wrap purely deprecated functions in:

//>>excludeStart("deprecated", kwArgs.deprecated == "off");
[code]
//>>excludeStop("deprecated");

This wouldn't be for any official release or version, but a nice option to have if you are working with strictly newer versions of Dojo, or otherwise know you aren't calling anything deprecated throughout your codebase. We do not do it internally at all.

Need to determine if duplicate labels for excludeStart() blocks is kosher, or if they would need to be named uniquely.

Change History (4)

comment:1 Changed 10 years ago by dante

Summary: [meta] provide buildExlude option for deprecated methods[meta] provide buildExclude option for deprecated methods

comment:2 Changed 10 years ago by James Burke

FYI: duplicate labels for excludeStart are fine as long as they are not nested.

It seems like this mostly something to be used in dijit?

comment:3 Changed 10 years ago by dante

Resolution: wontfix
Status: newclosed

this may just make the code too messy? The severity of this isn't pressing. Perhaps a +/- 1 from bill on doing this to dijit methods would help me along.

comment:4 Changed 10 years ago by bill

It seems like a good idea (and doesn't seem like it would be too messy).

I suspect we'll have a 1.5 before we have a 2.0, so it might be worthwhile.

Note: See TracTickets for help on using tickets.