Opened 10 years ago

Closed 10 years ago

Last modified 10 years ago

#8259 closed defect (fixed)

Dialog: leaks memory on IE

Reported by: bill Owned by: bill
Priority: high Milestone: 1.3
Component: Dijit Version: 1.2.1
Keywords: Cc:
Blocked By: Blocking:

Description

See test_Dialog.html on IE6 or IE7.

Showing the first dialog takes 5M (see memory increase in task manager), and then the following six dialogs take an addition 17M (on IE7) or 30M (on IE6).

Attachments (1)

underlay.patch (882 bytes) - added by dante 10 years ago.
proposed solution to being able to access the underlay easily still.

Download all attachments as: .zip

Change History (6)

comment:1 Changed 10 years ago by bill

Resolution: fixed
Status: newclosed

Fixed by [16044] (trac should have closed this automatically).

Changed 10 years ago by dante

Attachment: underlay.patch added

proposed solution to being able to access the underlay easily still.

comment:2 Changed 10 years ago by dante

(In [16072]) refs #8259 - the change to make all dialogs use a shared underlay is great, but breaks an easy path for dialog subclasses to access the underlay for anything reasonable. also: changing onBegin to beforeBegin because onBegin is fired in a timeout after starting an animation and beforeBegin in sync before an animation, so limiting some browser lag experienced in show(). also adding pseudo-inline docs for things.

comment:3 Changed 10 years ago by dante

(In [16073]) refs #8259 - this._underlay no longer exists. in [16072] I re-exposed access to the now shared _underlay instance dijit._underlay, and fixed dojox.widget.Dialog, which explicitly connects to the underlay onclick.

comment:4 Changed 10 years ago by bill

Also [16071].

comment:5 Changed 10 years ago by dante

(In [16078]) refs #8259 - moving the underlay connection to modalconnects so it is not firing when other shared dialogs use it.

Note: See TracTickets for help on using tickets.