Opened 15 years ago
Closed 14 years ago
#824 closed defect (fixed)
DomWidget.addChild() is not using the reference node passed into it
Reported by: | Owned by: | dylan | |
---|---|---|---|
Priority: | high | Milestone: | 0.9 |
Component: | DOM | Version: | 0.3 |
Keywords: | Cc: | ||
Blocked By: | Blocking: |
Description
DomWidget.addChild() is passed a pos and a ref, but the code seems to be ignoring ref.
DomWidget.addChild() calls addWidgetAsDirectChild, which calls insertAtPosition(). However, it is passing pos and cn to insertAtPosition(). This probably should be pos and ref.
In other words,
dojo.dom.insertAtPosition(widget.domNode, cn, pos);
should probably be changed to
dojo.dom.insertAtPosition(widget.domNode, ref, pos);
unless I'm missing something.
Change History (6)
comment:1 Changed 15 years ago by
comment:2 Changed 14 years ago by
Component: | General → DOM |
---|---|
Milestone: | → 0.4 |
Owner: | changed from anonymous to dylan |
Status: | new → assigned |
comment:3 Changed 14 years ago by
severity: | normal → blocker |
---|
comment:4 Changed 14 years ago by
Milestone: | 0.4 → 0.4.1 |
---|---|
severity: | blocker → normal |
comment:5 Changed 14 years ago by
Milestone: | 0.4.1 → 0.5 |
---|
comment:6 Changed 14 years ago by
Resolution: | → fixed |
---|---|
Status: | assigned → closed |
The new code in Dijit 0.9 gets an insertIndex only, and I think it's working.
Note: See
TracTickets for help on using
tickets.
Actually there is a FIXME nearby that may be related: