[patch][ccla]IE7: dojox.json.Rest range is undefined, causes exception

[Adam Peller]

This comes from Hernan Badenes (IBM, CCLA)

In dojox.json.Rest, a request object is created that is later used to build a XHR object. These arguments object contains the headers that will be sent in the HTTP GET (or POST, or ...): "Accept" and "Range". When querying for an individual object, the Range is assigned the value undefined. This throws an exception "Invalid procedure call or argument" in Internet Explorer (I tested IE7). (The exact place is in dojo._base.xhr, line 664, "xhr.setRequestHeader(hdr, args.headers[hdr]);")

The problem is that IE7 does not accept to setRequestHeader(propName, undefined). To avoid this, I think that dojox.rpc.Rest should not set that Range===undefined, but just skip it from the parameters when not using it.

Attached is a testcase that exposes this problem by just doing:

var store = new dojox.data.JsonRestStore?({ target: "/foo" }); store.byId({ identity: "42" });

this should perform a GET and likely yield in a http 404. But in IE7 it throws an exception. The code to patch is in Rest.js:

service._getRequest = getRequest

function(id, args){

return {

(...) headers: {

(...)

Range: args && (args.start >= 0

args.count >= 0) ? "items=" + (args.start	'0') + '-'

+ ((args.count && (args.count + (args.start 0) - 1)) ) : undefined

}

};

};

that "Range" property should be avoided. A proposed patch is attached as well.

[Adam Peller]

don't set Range in headers unless it's going to be defined

[Adam Peller]

test from Hernan

[Adam Peller]

(In [16106]) Don't set Range in headers unless it's going to be defined. Fixes #8228. Thanks, Hernan.