Opened 12 years ago
Closed 12 years ago
#8221 closed defect (fixed)
[patch] [cla] Dialog: use doh.robot to test aria and focus a11y
Reported by: | Joseph Scheuhammer | Owned by: | bill |
---|---|---|---|
Priority: | high | Milestone: | 1.3 |
Component: | Dijit | Version: | 1.2.1 |
Keywords: | doh robot a11y focus | Cc: | davidb, haysmark |
Blocked By: | Blocking: |
Description
It is time consuming to manually test that dijit.Dialog has it aria information properly set, and that it correctly places keyboard focus when shown. Such testing should be automated.
Attachments (2)
Change History (9)
comment:1 Changed 12 years ago by
comment:2 Changed 12 years ago by
Milestone: | tbd → 1.4 |
---|
comment:3 Changed 12 years ago by
Attaching "8221a.patch" that does the same tests as before, but using a loop to register the tests based on an array of dialog ids.
The problem noted above with FF3 on WinXP remains, but does not appear to have anything to do with the new "test_Dialog.html". For example, if robotTests.js is modified to run "test_Menu.html" first, the same problem occurs. And, if it's modified to run just "test_Dialog.html", that works too. This feels like a problem calling java.awt.Robot multiple times, but I'm not sure.
comment:4 Changed 12 years ago by
Summary: | Dialog: use doh.robot to test aria and focus a11y → [patch] [cla] Dialog: use doh.robot to test aria and focus a11y |
---|
comment:5 Changed 12 years ago by
Component: | General → Dijit |
---|
comment:6 Changed 12 years ago by
Milestone: | 1.4 → 1.3 |
---|---|
Owner: | changed from Becky Gibson to bill |
Status: | new → assigned |
I'll check this in along with some tests that I've written.
comment:7 Changed 12 years ago by
Resolution: | → fixed |
---|---|
Status: | assigned → closed |
Attaching an *interim* patch, "8221.patch" that:
role
"dialog" is properly set for the Dialog widget.aria-label
OR anaria-labelledby
property.The patch is "interim" since it does not work with FF3 on WinXP. Specifically, if the test file "test_Dialog.html" is added to the list of files to run with the doh testing harness, the testing harness hangs upon loading "test_Dialog.html". It does not hang for FF2/WinXP, IE7/WinXP, FF2/MacOSX, nor FF3/MacSX.
(Note: applying the patch modifies "robotTests.js" to load the "test_Dialog.html" tests using the test harness.)