Opened 11 years ago

Closed 11 years ago

#8221 closed defect (fixed)

[patch] [cla] Dialog: use doh.robot to test aria and focus a11y

Reported by: Joseph Scheuhammer Owned by: bill
Priority: high Milestone: 1.3
Component: Dijit Version: 1.2.1
Keywords: doh robot a11y focus Cc: davidb, haysmark
Blocked By: Blocking:

Description

It is time consuming to manually test that dijit.Dialog has it aria information properly set, and that it correctly places keyboard focus when shown. Such testing should be automated.

Attachments (2)

8221.patch (8.6 KB) - added by Joseph Scheuhammer 11 years ago.
Interim patch. DO NOT COMMIT.
8221a.patch (6.6 KB) - added by Joseph Scheuhammer 11 years ago.
Test aria role, aria label, and focus a11y

Download all attachments as: .zip

Change History (9)

comment:1 Changed 11 years ago by Joseph Scheuhammer

Attaching an *interim* patch, "8221.patch" that:

  • checks that the aria role "dialog" is properly set for the Dialog widget.
  • checks that the dialog has either a non-null, non-empty aria-label OR an aria-labelledby property.
  • checks that the declared first-focusable item is in fact the one that receives focus when the dialog is shown.

The patch is "interim" since it does not work with FF3 on WinXP. Specifically, if the test file "test_Dialog.html" is added to the list of files to run with the doh testing harness, the testing harness hangs upon loading "test_Dialog.html". It does not hang for FF2/WinXP, IE7/WinXP, FF2/MacOSX, nor FF3/MacSX.

(Note: applying the patch modifies "robotTests.js" to load the "test_Dialog.html" tests using the test harness.)

Changed 11 years ago by Joseph Scheuhammer

Attachment: 8221.patch added

Interim patch. DO NOT COMMIT.

comment:2 Changed 11 years ago by Becky Gibson

Milestone: tbd1.4

comment:3 Changed 11 years ago by Joseph Scheuhammer

Attaching "8221a.patch" that does the same tests as before, but using a loop to register the tests based on an array of dialog ids.

The problem noted above with FF3 on WinXP remains, but does not appear to have anything to do with the new "test_Dialog.html". For example, if robotTests.js is modified to run "test_Menu.html" first, the same problem occurs. And, if it's modified to run just "test_Dialog.html", that works too. This feels like a problem calling java.awt.Robot multiple times, but I'm not sure.

Changed 11 years ago by Joseph Scheuhammer

Attachment: 8221a.patch added

Test aria role, aria label, and focus a11y

comment:4 Changed 11 years ago by Joseph Scheuhammer

Summary: Dialog: use doh.robot to test aria and focus a11y[patch] [cla] Dialog: use doh.robot to test aria and focus a11y

comment:5 Changed 11 years ago by bill

Component: GeneralDijit

comment:6 Changed 11 years ago by bill

Milestone: 1.41.3
Owner: changed from Becky Gibson to bill
Status: newassigned

I'll check this in along with some tests that I've written.

comment:7 Changed 11 years ago by bill

Resolution: fixed
Status: assignedclosed

(In [16999]) Dialog a11y tests (keyboard and aria roles). Fixes #8221 !strict (Contains patch from clown plus some tests I wrote too)

Note: See TracTickets for help on using tickets.