Opened 11 years ago

Closed 11 years ago

#8209 closed enhancement (fixed)

[dojox.data] CsvStore identitiy enhancement

Reported by: dante Owned by: Jared Jurkiewicz
Priority: high Milestone: 1.3
Component: DojoX Data Version: 1.2.1
Keywords: Cc: dante
Blocked By: Blocking:

Description

Currently, the CsvStore uses the row index of the line for a given item by identity. I would like to suggest there be an optional 'identifier' constructor param, which will use a named column as the identity value, defaulting to the rowIndex preserving backwards compat.

The use case is such that: FilteringSelect uses the identity value for it's post'ing / getValue work, which could be a design flaw there, but allowing a column to act as a single value would allow for more transparent use, and is much easier to fix here (as opposed to a potentially breaking filteringselect change)

assigning to you as owner. I will attach a patch if I am able to come up with a quick fix, though you seemed to think it would be fairly trivial to implement.

Whichever is decided upon, we need to update the docs for CsvStore? to clarify this, and provide examples of getting the value of a named column from an item reference by row.

Attachments (1)

dojox.data.CsvStore_20081202.patch (20.4 KB) - added by Jared Jurkiewicz 11 years ago.

Download all attachments as: .zip

Change History (4)

comment:1 Changed 11 years ago by Jared Jurkiewicz

Milestone: tbd1.3
Status: newassigned

Changed 11 years ago by Jared Jurkiewicz

comment:2 Changed 11 years ago by Jared Jurkiewicz

Did the patch work for what you wished?

comment:3 Changed 11 years ago by Jared Jurkiewicz

Resolution: fixed
Status: assignedclosed

(In [16002]) Added in identity support. \!strict fixes #8209

Note: See TracTickets for help on using tickets.