Opened 11 years ago

Closed 10 years ago

#8188 closed defect (fixed)

ComboBox: horizontally align text in dropdown list with text in entry field

Reported by: Scott Lewis Owned by:
Priority: high Milestone: 1.5
Component: Dijit - LnF Version: 1.2.1
Keywords: Cc:
Blocked By: Blocking:

Description (last modified by bill)

Horizontally align items in dropdown list with item in entry field. There is about a 2 pixel indent to the items in the drop down list

Attachments (1)

combobox.png (7.9 KB) - added by bill 11 years ago.
screen shot with red bar showing alignment problem

Download all attachments as: .zip

Change History (12)

comment:1 Changed 11 years ago by bill

Component: design/interactionsDijit - LnF
Owner: itorrey deleted

I assume you mean horizontal alignment? The drop down text seems to be a little too far to the right.

comment:2 Changed 11 years ago by Scott Lewis

yes, the drop down ext is a bit too far to the right

comment:3 Changed 11 years ago by bill

Description: modified (diff)
Summary: ComboBox - Vertically align items in dropdown list with item in entry field.ComboBox: horizontally align items in dropdown list with item in entry field

comment:4 Changed 11 years ago by bill

Hmm, I looked at this again (http://archive.dojotoolkit.org/nightly/dojotoolkit/dijit/tests/form/test_ComboBox.html) and I don't see any issue. Which browser did you see the problem on, and what was your testcase?

From my tests the drop down is exactly aligned, but in safari, there's the fuzzy blue focus outline which does extend to the left and right of both the ComboBox? and the drop down. Is that what you were referring to?

comment:5 Changed 11 years ago by bill

Oh I see this in IE8, maybe it's an IE only problem (or IE8 only).

comment:6 Changed 11 years ago by Douglas Hays

I only see a problem in IE8. This may be a dup of #8047

comment:7 Changed 11 years ago by bill

Summary: ComboBox: horizontally align items in dropdown list with item in entry fieldComboBox: horizontally align text in dropdown list with text in entry field

I'm pretty sure this ticket wasn't against IE8, it was either FF or maybe IE. Oh I see, it's about aligning the text. On FF it seems to be off by 1 pixel:

screen shot with red bar showing alignment problem

Changed 11 years ago by bill

Attachment: combobox.png added

screen shot with red bar showing alignment problem

comment:8 Changed 11 years ago by bill

The drop down menu has a padding of 0.2em, 3px on my display, since it's using the standard rules for dijitMenuItem. The <input> itself has padding:0 but the browser is adding padding anyway, although not as much, only 2px.

comment:9 Changed 11 years ago by bill

Milestone: tbd1.5

comment:10 Changed 10 years ago by bill

It's working on claro, the new theme, except for IE8 where there's still a problem, so leaving ticket open.

comment:11 Changed 10 years ago by bill

Resolution: fixed
Status: newclosed

IE8 now looks OK to me, so closing this.

Note: See TracTickets for help on using tickets.