Opened 12 years ago
Closed 12 years ago
#8178 closed defect (fixed)
dojox.string.BidiComplex violates global namespace in many places
Reported by: | dylan | Owned by: | Adam Peller |
---|---|---|---|
Priority: | high | Milestone: | 1.3 |
Component: | String | Version: | 1.2.1 |
Keywords: | Cc: | [email protected]… | |
Blocked By: | Blocking: |
Description
Given the number of global namespace violations in this file, I'm not comfortable fixing it... I'm not sure how this got checked in as-is, but let's just get it fixed please and thank you. :)
obj, lines 66, 73, 138 str0, line 67 str1, lines 74, 100, 120, 126, 135 ieKey, lines 80, 99, 119, 125, 140 str2, 133 range, lines 165 and 200 i, line 375 preStr, line 378 postStr, line 379
Change History (3)
comment:1 Changed 12 years ago by
Cc: | [email protected]… added |
---|---|
Milestone: | tbd → 1.3 |
comment:2 Changed 12 years ago by
removed some in [15908]. Looks like some globals are passed around and API may not be safe across multiple instances.
comment:3 Changed 12 years ago by
Resolution: | → fixed |
---|---|
Status: | new → closed |
I think Lena got the last of them in [16122]. Some other cleanup remains.
Note: See
TracTickets for help on using
tickets.
It's marked experimental, which implies there's a lot of work to be done (see FIXME). Yeah, a lot of these globals were flagged, but never fixed. Thanks for the reminder.