Opened 12 years ago

Last modified 12 years ago

#8140 closed defect

combine XML DOM creation code — at Version 1

Reported by: Adam Peller Owned by: Jared Jurkiewicz
Priority: high Milestone: 1.3
Component: Dojox Version: 1.2.1
Keywords: Cc: James Burke
Blocked By: Blocking:

Description (last modified by Adam Peller)

_base.xhr, dojo.io.frame, dojox.data.dom and dojox.xml.parser all implement logic to instantiate the IE ActiveX XMLDOM, which is brittle as it is. Combine the code. Also, consider deprecating dojox.data.dom.createDocument.

Consider using the code in the _base.query test for maximum reuse. It's really not that bad a kludge, on second thought.

			function createDocument(xml){
				var fauxXhr = { responseText: xml };
				if("DOMParser" in dojo.global){
					var parser = new DOMParser();
					fauxXhr.responseXML = parser.parseFromString(xml, "text/xml");
				}
				// kludge: use dojo.xhr contentHandler for XML to process IE XMLDOC as needed
				return dojo._contentHandlers["xml"](fauxXhr); // DOMDocument
			}

Change History (2)

comment:1 Changed 12 years ago by Adam Peller

Cc: James Burke added
Description: modified (diff)

Changed 12 years ago by Jared Jurkiewicz

Attachment: dojox.xml_20081201.patch added

Initial patch that moves the dojox.data.dom functions to dojox.xml, and does some general cleanup on projects that used dojox.data.dom

Note: See TracTickets for help on using tickets.