Opened 12 years ago
Closed 12 years ago
#8140 closed defect (fixed)
combine XML DOM creation code
Reported by: | Adam Peller | Owned by: | Jared Jurkiewicz |
---|---|---|---|
Priority: | high | Milestone: | 1.3 |
Component: | Dojox | Version: | 1.2.1 |
Keywords: | Cc: | James Burke | |
Blocked By: | Blocking: |
Description (last modified by )
_base.xhr, dojo.io.frame, dojox.data.dom and dojox.xml.parser all implement logic to instantiate the IE ActiveX XMLDOM, which is brittle as it is. Combine the code. Also, consider deprecating dojox.data.dom.createDocument.
Consider using the code in the _base.query test for maximum reuse. It's really not that bad a kludge, on second thought.
function createDocument(xml){ var fauxXhr = { responseText: xml }; if("DOMParser" in dojo.global){ var parser = new DOMParser(); fauxXhr.responseXML = parser.parseFromString(xml, "text/xml"); } // kludge: use dojo.xhr contentHandler for XML to process IE XMLDOC as needed return dojo._contentHandlers["xml"](fauxXhr); // DOMDocument }
Attachments (1)
Change History (10)
comment:1 Changed 12 years ago by
Cc: | James Burke added |
---|---|
Description: | modified (diff) |
Changed 12 years ago by
Attachment: | dojox.xml_20081201.patch added |
---|
comment:2 Changed 12 years ago by
comment:6 Changed 12 years ago by
Status: | new → assigned |
---|
comment:8 Changed 12 years ago by
Milestone: | tbd → 1.3 |
---|
comment:9 Changed 12 years ago by
Resolution: | → fixed |
---|---|
Status: | assigned → closed |
Going ahead and closing this as the code has been moved, tested, etc.
Note: See
TracTickets for help on using
tickets.
Initial patch that moves the dojox.data.dom functions to dojox.xml, and does some general cleanup on projects that used dojox.data.dom