Opened 11 years ago

Closed 8 years ago

#8114 closed enhancement (wontfix)

dojo.delegate isn't good with Arrays

Reported by: alex Owned by:
Priority: low Milestone: future
Component: Core Version: 1.2.1
Keywords: delegate, clone, object, array needsreview Cc: Eugene Lazutkin
Blocked By: Blocking:

Description

dojo.delegate inelegantly handles arrays. It should likely hand back the result of a _toArray() call. Also, delegate should punt on things that aren't objects.

Change History (9)

comment:1 Changed 11 years ago by alex

Status: newassigned

note to self: delegate also blows when it comes to functions.

comment:2 Changed 11 years ago by dante

Milestone: 1.3future

comment:3 Changed 9 years ago by Chris Mitchell

Owner: changed from alex to dylan

please review/triage

comment:4 Changed 9 years ago by dylan

Owner: changed from dylan to none
Status: assignednew

comment:5 Changed 9 years ago by bill

Type: defectenhancement

comment:6 Changed 9 years ago by bill

Owner: none deleted

comment:7 Changed 9 years ago by Eugene Lazutkin

dojo.delegate() is effectively enshrined in Object.create(). I suspect we should strive to be compatible with the latter, and drop edge cases guided by "garbage in, garbage out" principle.

comment:8 Changed 8 years ago by ben hockey

Keywords: needsreview added
Priority: highlow

agree with elazutkin - should we close this?

comment:9 Changed 8 years ago by bill

Resolution: wontfix
Status: newclosed

I third your motion... closing it.

Note: See TracTickets for help on using tickets.