Opened 12 years ago
Closed 11 years ago
#8100 closed defect (worksforme)
[CLA-patch] ComboBox in a Dialog : e.preventDefault() issue with Firefox
Reported by: | Jonathan Bond-Caron | Owned by: | bill |
---|---|---|---|
Priority: | high | Milestone: | 1.5 |
Component: | DnD | Version: | 1.2.1 |
Keywords: | Cc: | ||
Blocked By: | Blocking: |
Description
Context: While trying to show ComboBox? inside a Dialog, when moving the Dialog overlay, the popup box does not close in Firefox.
Solution: Do not call e.preventDefault() in dojo.dnd.Moveable (FF only)
Attached is a patch for dojo and dijit. Also a viewport calculation fix for Opera (Dialog)
Attachments (3)
Change History (12)
Changed 12 years ago by
Attachment: | dojo.patch added |
---|
Changed 12 years ago by
Attachment: | dijit.patch added |
---|
comment:1 Changed 12 years ago by
Component: | Dijit → DnD |
---|---|
Owner: | set to Eugene Lazutkin |
comment:2 Changed 12 years ago by
Milestone: | tbd → 1.2.3 |
---|---|
Status: | new → assigned |
comment:3 Changed 12 years ago by
Eugene, is this critical and well-tested for 1.2.3? If so, it needs to go in now.
comment:4 Changed 12 years ago by
Owner: | changed from Eugene Lazutkin to bill |
---|---|
Status: | assigned → new |
The attached fix for Moveable is no good --- text starts to get selected randomly when the fix is in place. Try http://archive.dojotoolkit.org/nightly/dojotoolkit/dojo/tests/dnd/test_moveable.html before doing anything drastic.
Reassigning to Bill for his consideration.
comment:5 Changed 12 years ago by
Milestone: | 1.2.3 → 1.3 |
---|
comment:6 Changed 12 years ago by
Milestone: | 1.3 → 1.4 |
---|
I'm sure there's another fix, like popup.js monitoring drag-start operations (there's a published topic for that) and closing all drop downs.
comment:7 Changed 12 years ago by
Milestone: | 1.4 → 1.5 |
---|
comment:8 Changed 11 years ago by
This ticket can be closed, e.preventDefault() in dojo.dnd.Moveable was bad.
It's been resolved somehow / not sure at which revision :)
Working on Firefox 3.0.19 and 3.6.3
comment:9 Changed 11 years ago by
Resolution: | → worksforme |
---|---|
Status: | new → closed |
I fixed getViewport() in [15845]. As for the main point of this ticket, handing to Eugene since it's really a DnD issue.