[CLA-patch] ComboBox in a Dialog : e.preventDefault() issue with Firefox

[Jonathan Bond-Caron]

Context: While trying to show ComboBox? inside a Dialog, when moving the Dialog overlay, the popup box does not close in Firefox.

Solution: Do not call e.preventDefault() in dojo.dnd.Moveable (FF only)

Attached is a patch for dojo and dijit. Also a viewport calculation fix for Opera (Dialog)

[bill]

I fixed getViewport() in [15845]. As for the main point of this ticket, handing to Eugene since it's really a DnD issue.

[Adam Peller]

Eugene, is this critical and well-tested for 1.2.3? If so, it needs to go in now.

[Eugene Lazutkin]

The attached fix for Moveable is no good --- text starts to get selected randomly when the fix is in place. Try ​http://archive.dojotoolkit.org/nightly/dojotoolkit/dojo/tests/dnd/test_moveable.html before doing anything drastic.

Reassigning to Bill for his consideration.

[bill]

I'm sure there's another fix, like popup.js monitoring drag-start operations (there's a published topic for that) and closing all drop downs.

[Jonathan Bond-Caron]

Test case, this seems resolved

[Jonathan Bond-Caron]

This ticket can be closed, e.preventDefault() in dojo.dnd.Moveable was bad.

It's been resolved somehow / not sure at which revision :)

Working on Firefox 3.0.19 and 3.6.3