Opened 11 years ago

Closed 11 years ago

#8091 closed defect (fixed)

If LI has some internal structure including inner li, the inner li should not be rolled.

Reported by: youngho Owned by: dante
Priority: high Milestone: 1.3
Component: DojoX Widgets Version: 1.2.1
Keywords: Roller Cc:
Blocked By: Blocking:

Description

If UL has a complicated structure like <ul>

<li>Coffee</li> <li>Tea

<ul>

<li>Black tea</li> <li>Green tea</li>

</ul>

</li> <li>Milk</li>

</ul>

I think, the rolling item should be the Coffee, Tea and Milk only.

Attachments (1)

roller.patch (655 bytes) - added by youngho 11 years ago.
The first patch is wrong. I don't know how I can get the children using query, but second one is working.

Download all attachments as: .zip

Change History (4)

Changed 11 years ago by youngho

Attachment: roller.patch added

The first patch is wrong. I don't know how I can get the children using query, but second one is working.

comment:1 Changed 11 years ago by dante

Status: newassigned

@youngho - try out: dojo.query(">li", this.domNode) instead. that will select only first-children of the initial UL. I agree this should be the default, so if you report back it works out okay for you, I'll happily implement. maybe a public parameter would be better serve people? childrenSelector:">li" and then later dojo.query(this.childrenSelector, this.domNode) ?

comment:2 Changed 11 years ago by dante

Milestone: tbd1.3

comment:3 Changed 11 years ago by dante

Resolution: fixed
Status: assignedclosed

fixed in [15800]

Note: See TracTickets for help on using tickets.