Opened 13 years ago

Closed 13 years ago

Last modified 12 years ago

#809 closed defect (fixed)

dom.isNode is defined incorrectly [patch]

Reported by: cyology@… Owned by: dylan
Priority: high Milestone:
Component: DOM Version: 0.3
Keywords: dom Cc:
Blocked By: Blocking:

Description

The typeof Element, a class, is correctly identified as 'function' if it is defined. Thus, dom.isNode should test if typeof Element == 'function' instead of 'object'.

Only tested on Firefox 1.5.0.3 WinXP but it involves JavaScript? spec.

Attachments (1)

dom_isNode_patch​ (324 bytes) - added by anonymous 13 years ago.

Download all attachments as: .zip

Change History (7)

comment:1 Changed 13 years ago by dylan

Milestone: → 0.4

Changed 13 years ago by anonymous

Attachment: dom_isNode_patch​ added

comment:2 Changed 13 years ago by gavin@…

Submitted this (trivial) patch after some ad-hoc testing in Firefox, IE6 and Safari. typeof Element is either undefined or 'function' in all browsers.

comment:3 Changed 13 years ago by gavin@…

Summary: dom.isNode is defined incorrectly → dom.isNode is defined incorrectly [patch]

(changed trac title)

comment:4 Changed 13 years ago by dylan

Component: Core → DOM
Owner: changed from anonymous to dylan
Status: new → assigned

comment:5 Changed 13 years ago by dylan

Resolution: → fixed
Status: assigned → closed

Thanks for the patch gavin, fixed in [4973]

comment:6 Changed 12 years ago by (none)

Milestone: 0.4

Milestone 0.4 deleted

Note: See TracTickets for help on using tickets.