Opened 11 years ago

Closed 11 years ago

Last modified 8 years ago

#8088 closed defect (fixed)

FilteringSelect - required defaults to true

Reported by: ben hockey Owned by: Douglas Hays
Priority: high Milestone: 1.3
Component: Dijit - Form Version: 1.2.1
Keywords: Cc:
Blocked By: Blocking:

Description

The API says that required will default to false but it defaults to true

Attachments (2)

test.html​ (1.1 KB) - added by ben hockey 11 years ago.
8088.diff​ (607 bytes) - added by ben hockey 11 years ago.

Download all attachments as: .zip

Change History (8)

Changed 11 years ago by ben hockey

Attachment: test.html​ added

Changed 11 years ago by ben hockey

Attachment: 8088.diff​ added

comment:1 Changed 11 years ago by bill

Owner: set to Douglas Hays

Maybe we should just update the documentation (IE, add a comment in FilteringSelect?.js for that attribute)?

I forget why required=true for FilteringSelect. Perhaps for backwards-compatibility.

comment:2 Changed 11 years ago by Douglas Hays

Resolution: → fixed
Status: new → closed

[15785] Fixes #8088. Added a comment to FilteringSelect?.js to say that required defaults to true since the superclass ValidationTextBox? defaults to false. This widget uses true for a default for backward compatibility since FilteringSelect? did not like blank values in some of the older releases.

comment:3 Changed 11 years ago by Douglas Hays

Milestone: tbd → 1.3

comment:4 Changed 8 years ago by bill

Component: Dijit → Dijit - Form

comment:5 Changed 8 years ago by adros

I cannot find anything about this different default in current documentation of FilteringSelect?. Was it removed from it? If yes, why? Because the behaviour is still same (different from superclass).

comment:6 Changed 8 years ago by Douglas Hays

required=true for FilteringSelect? but the API doc tool sometimes doesn't show all property values

Note: See TracTickets for help on using tickets.