Opened 13 years ago

Closed 13 years ago

#8072 closed defect (fixed)

Nodelist.html / query() unit test failure (firefox-lite)

Reported by: bill Owned by: James Burke
Priority: high Milestone: 1.3
Component: Core Version: 1.2.1
Keywords: Cc:
Blocked By: Blocking:

Description (last modified by bill), dojo.query("body").query(":last-child")[0]);, dojo.query("body").query(":last-child")[1]);

The lines above assume that the content of <body> is unchanged from the original HTML of the page, which is not true when the Firebug Lite console is present, which it is, except on FF/Safari.

Suggest to just remove the lines.

Refs #2615.

Noticed this w/IE8 testing but I don't think it's limited to IE8.

Change History (7)

comment:1 Changed 13 years ago by bill

Description: modified (diff)

comment:2 Changed 13 years ago by James Burke

Milestone: tbd1.3
Owner: changed from anonymous to James Burke

Maybe we could use djConfig.debugContainerId = "someDomId" to fix the issue, so we can make sure firebug is not interfering with the order of the nodes. Or maybe change the test to work on a dom node that has children.

comment:3 Changed 13 years ago by bill

Sure, either of those is fine.

comment:4 Changed 13 years ago by James Burke

Something else is going on. Even if I do isDebug=false on NodeList?.html test page, when I load the page stand-alone in IE8, and try dojo.query("body").query(":last-child") in the IE8 console, I get an "invalid argument". ":first-child" works ok though.

comment:5 Changed 13 years ago by bill

Yes, see #8073 and #8074.

comment:6 Changed 13 years ago by James Burke

Priority: normalhigh

comment:7 Changed 13 years ago by James Burke

Resolution: fixed
Status: newclosed

Between IE8rc1, the new dojo.query and tests, this seems to be fixed. I tried:


In Firefox 3, IE6, 7, 8 , 8 in IE7 emulation, Safari 3.1.2 and Chrome, and Opera 9.63. This particular issue is fine. webkit browsers had some issues in NodeList?, but I'll file a separate ticket for that. Opera was weird on some tests, but from what I can tell not on this issue.

Note: See TracTickets for help on using tickets.