Opened 11 years ago

Closed 11 years ago

Last modified 10 years ago

#8048 closed defect (fixed)

Firebug lite broken in 1.2.1 release

Reported by: mcbenton Owned by: James Burke
Priority: high Milestone: 1.2.2
Component: Core Version: 1.2.0
Keywords: Cc:
Blocked By: Blocking:

Description

Downloaded this release:

http://download.dojotoolkit.org/release-1.2.1/dojo-release-1.2.1.tar.gz

Created a basic page with djConfig="isDebug:true" and in IE7 and Safari when you click on the DOM button in the debug console you get an error:

consoleDomInspector is undefined (in IE) Can't find variable: consoleDomInspector (in Safari)

It looks like somehow the build process didn't shrink the variables in dojo/_firebug/firebug.js (line 107).

I tried a custom build with the same code base (http://download.dojotoolkit.org/current-stable/dojo-release-1.2.1-src.tar.gz) and this problem didn't occur.

Change History (6)

comment:1 Changed 11 years ago by Adam Peller

Owner: changed from anonymous to Mike Wilcox

comment:2 Changed 11 years ago by James Burke

My guess is this is the old shrinksafe bugs about variables declared after functions that use those variables do not get the right variable substitution.

A quick fix may be to move all the var declarations to the top of the anon function before the window.console work happens in _firebug/firebug.js.

This probably shows up in the release vs a custom build since the release does an optimize=shrinksafe in the build command where the custom build may not be specifying that. If it is not specified, then shrinksafe is not run on the _firebug/firebug.js file.

comment:3 Changed 11 years ago by James Burke

Owner: changed from Mike Wilcox to James Burke

Stealing this since i'm currently working in firebug.js, but Mike please check my work since you are more familiar with it.

comment:4 Changed 11 years ago by James Burke

Milestone: tbd1.3
Resolution: fixed
Status: newclosed

Fixed in [15721]. Hmm trac/svn synch not working?

comment:5 Changed 11 years ago by James Burke

Milestone: 1.31.2.2

comment:6 Changed 11 years ago by James Burke

Fixed in 1.2 branch in [15722].

Note: See TracTickets for help on using tickets.