Opened 12 years ago
Closed 12 years ago
#8040 closed defect (fixed)
[PATCH][CCLA]: IE: Scroll/resize problem with grid
Reported by: | Jared Jurkiewicz | Owned by: | Nathan Toone |
---|---|---|---|
Priority: | high | Milestone: | 1.3 |
Component: | DojoX Grid | Version: | 1.2.0 |
Keywords: | Cc: | ||
Blocked By: | Blocking: |
Description
Reported by a co-worker of mine, verified by me it does occur.
This happens in IE but not in FF using the following test case:
http://download.dojotoolkit.org/release-1.2.1/dojo-release-1.2.1/dojox/grid/tests/test_grid.html
- Scroll to the most right using horizontal scrollbar
- Resize the right border of "Column3" column to a minimum width
Header and content won't line up properly
There is a workaround though. If you scroll using the vertical or horizontal scrollbar, header/content alignment will be fixed.
Attachments (1)
Change History (11)
comment:1 Changed 12 years ago by
Owner: | changed from Bryan Forbes to Nathan Toone |
---|
comment:2 Changed 12 years ago by
Milestone: | tbd → 1.3 |
---|
comment:3 Changed 12 years ago by
Priority: | normal → high |
---|---|
severity: | normal → major |
comment:4 Changed 12 years ago by
Milestone: | 1.3 → future |
---|
comment:5 Changed 12 years ago by
Same sort of problem on IE 7:
Seen on IE7 using dojox.grid.DataGrid? test at http://download.dojotoolkit.org/release-1.2.3/dojo-release-1.2.3/dojox/grid/tests/test_data_grid.html
Expand the width of the Country/Continent? Name column so that a horizontal scroll bar appears on the grid. Then scroll the grid to the right and drag the column back to make it smaller. The result is that the column headers no longer align with the column data.
Changed 12 years ago by
Attachment: | dojox.grid_20090217.patch added |
---|
Potential patch for this issue.
comment:6 Changed 12 years ago by
Summary: | IE: Scroll/resize problem with grid → [PATCH][CCLA]: IE: Scroll/resize problem with grid |
---|
I did some further diagnostics on this issue and found a potential solution that is extremely simple. I moved one line in an update function to look up the left position after an update, not before. This resolved the position problem reported in this defect on Ie quite nicely and I haven't seen any other issues on FF and Safari from the move.
Can you review the patch and if you're happy with it, commit it? Or let me know and I'll commit it?
comment:7 Changed 12 years ago by
That patch looks good - it does make sense to update the value after the grid and views have been updated.
Go ahead and commit it.
comment:8 Changed 12 years ago by
Okay, cool. I've got a real app also doing some testing against it before I commit it as a double-check.
comment:9 Changed 12 years ago by
Milestone: | future → 1.3 |
---|
Tests here confirmed working across a variety of browsers in a real-world app. So ... committing.
comment:10 Changed 12 years ago by
Resolution: | → fixed |
---|---|
Status: | new → closed |
Reassigning to me