Opened 11 years ago

Closed 11 years ago

#8022 closed enhancement (fixed)

Make dojo._Line.getValue a prototype method

Reported by: Neil Roberts Owned by: dante
Priority: high Milestone: 1.3
Component: fx Version: 1.2.0
Keywords: Cc:
Blocked By: Blocking:

Description

Right now it's created in the constructor

Attachments (2)

line.diff (1.1 KB) - added by Neil Roberts 11 years ago.
Using dojo.declare to create dojo._Line
fx.diff (6.9 KB) - added by dante 11 years ago.
patch to fix this and style cleanups

Download all attachments as: .zip

Change History (4)

Changed 11 years ago by Neil Roberts

Attachment: line.diff added

Using dojo.declare to create dojo._Line

comment:1 Changed 11 years ago by dante

Milestone: tbd1.3
Status: newassigned

so it is tremendously faster to not use declare here, but rather do

dojo._Line.prototype.getValue = function(n){...}

but is slightly larger on the wire. In implementing this fix, and a fix for #7858 - we have a delta of +30 bytes after gzip, and gain a performance boost in animation instantiation, so I think it wins.

Changed 11 years ago by dante

Attachment: fx.diff added

patch to fix this and style cleanups

comment:2 Changed 11 years ago by dante

Resolution: fixed
Status: assignedclosed

fixed in [15846]

Note: See TracTickets for help on using tickets.