Opened 11 years ago

Closed 11 years ago

#8021 closed defect (fixed)

[Patch][Cla] MinorLabels don't work in dojox.charting.axis2d

Reported by: rdunklau Owned by: Eugene Lazutkin
Priority: high Milestone: 1.2.2
Component: Charting Version: 1.2.0
Keywords: Dojox Charting Cc:
Blocked By: Blocking:

Description (last modified by Eugene Lazutkin)

Hello.

I've noticed that i could not add minorLabels (with the minorLabels option).

It comes from the fact that it uses c.scale (c referring at this.scaler in the Axis context), which is always undefined. This result in "can label" being always false.

canLabel = c.minMinorStep <= c.minor.tick * c.scale;

must be corrected in :

canLabel = c.minMinorStep <= c.minor.tick * c.bounds.scale;

See the attached patch.

This must be a mistake, and should be c.bounds.scale.

Attachments (1)

AxisMinorTicksLabels.patch (515 bytes) - added by rdunklau 11 years ago.
The concrete patch for the above correction (CLA)

Download all attachments as: .zip

Change History (3)

Changed 11 years ago by rdunklau

Attachment: AxisMinorTicksLabels.patch added

The concrete patch for the above correction (CLA)

comment:1 Changed 11 years ago by Eugene Lazutkin

Description: modified (diff)
Milestone: tbd1.2.2
Status: newassigned

Yep, looks like a typo. (I corrected the bad line in your description to match the bad code).

comment:2 Changed 11 years ago by Eugene Lazutkin

Resolution: fixed
Status: assignedclosed

Trac is acting up and not tracking changesets. :-(

This problem was fixed in the trunk.

Note: See TracTickets for help on using tickets.