#8016 closed defect (fixed)
[REGRESSION] brackets in RadioButton's name breaks them
Reported by: | regilero | Owned by: | Douglas Hays |
---|---|---|---|
Priority: | high | Milestone: | 1.3 |
Component: | Dijit - Form | Version: | 1.2.0 |
Keywords: | radiobutton regression brackets | Cc: | |
Blocked By: | Blocking: |
Description
using radioButton with a name like "foo[bar]" makes thems unsuable. When you select a radio check he is seleced but previous entries aren't unchecked. And you cannot uncheck any checked entry. This was working with 1.1.0.
The bug is in the new _setCheckedAttr: in dijit/form/Checkbox.js
line 129:
dojo.query('INPUT[type=radio][name='+this.name+']', this.focusNode.form||dojo.doc).forEach(
this.name cannot be a name containg brackets. I found a workaround by reading ticket #6834. Changing the line to handle the possibility of having brackets in the name (which is very important for me, my names are foo[bar][toto][titi] and I do not want to break this):
dojo.query("INPUT[type=radio][name^='"+this.name+"']",this.focusNode.form||dojo.doc).forEach(
Change History (9)
comment:1 Changed 12 years ago by
Owner: | set to Douglas Hays |
---|
comment:2 Changed 12 years ago by
comment:3 follow-up: 4 Changed 12 years ago by
Milestone: | tbd → 1.3 |
---|
Adding the begins-with () operator as suggested seems incorrect.
comment:4 Changed 12 years ago by
Replying to doughays:
Adding the begins-with (\) operator as suggested seems incorrect.
comment:5 Changed 12 years ago by
Resolution: | → fixed |
---|---|
Status: | new → closed |
comment:6 Changed 12 years ago by
The bug described in this ticket still needs to be fixed in current trunk.
comment:7 Changed 12 years ago by
Resolution: | fixed |
---|---|
Status: | closed → reopened |
comment:8 Changed 12 years ago by
Resolution: | → fixed |
---|---|
Status: | reopened → closed |
comment:9 Changed 10 years ago by
Component: | Dijit → Dijit - Form |
---|
It seems to be invalid per http://www.w3.org/TR/html401/types.html#type-name