Opened 11 years ago

Closed 11 years ago

Last modified 7 years ago

#8000 closed defect (fixed)

[patch] [cla] Tree: use doh.robot to test keyboard a11y

Reported by: Joseph Scheuhammer Owned by: Becky Gibson
Priority: high Milestone: 1.3
Component: Accessibility Version: 1.2.0
Keywords: doh robot a11y keystrokes Cc: davidb, haysmark
Blocked By: Blocking:

Description (last modified by Joseph Scheuhammer)

Manually testing that dijit.Tree is keyboard accessible, and that it implements the keystrokes as documented, is time consuming. Such testing should be automated.

Also, there should be tests for the aria properties for tree and its nodes.

Attachments (2)

8000.patch (8.4 KB) - added by Joseph Scheuhammer 11 years ago.
8000a.patch (17.1 KB) - added by Joseph Scheuhammer 11 years ago.

Download all attachments as: .zip

Change History (13)

comment:1 Changed 11 years ago by Joseph Scheuhammer

The attached patch, "8000.patch", has automated tests for:

  • aria roles for tree
  • aria-expanded state for tree (will fail until patch for #7998 is applied)
  • aria roles for tree nodes
  • aria-expanded state for tree nodes
  • tab navigation to and from tree
  • tab navigation to and from when a leaf was focussed before tabbing away.

Changed 11 years ago by Joseph Scheuhammer

Attachment: 8000.patch added

comment:2 Changed 11 years ago by Joseph Scheuhammer

Description: modified (diff)

comment:3 Changed 11 years ago by Joseph Scheuhammer

Summary: Tree: use doh.robot to test keyboard a11y[patch] [cla] Tree: use doh.robot to test keyboard a11y

Attaching patch, "8000a.patch" that, in addition to doing everything that the "8000.patch" does, includes robot tests for keyboard a11y:

  • expand/collapse nodes using arrow keys.
  • use of DOWN and RIGHT arrows to navigate to the first leaf.
  • use of HOME and END keys to navigate to the first and last visible nodes in the tree.

Note that the tests of the END keystroke will fail, pending resolution of #8028.

Changed 11 years ago by Joseph Scheuhammer

Attachment: 8000a.patch added

comment:4 Changed 11 years ago by Becky Gibson

Milestone: tbd1.3

this just needs review and checkin so moving back to 1.3

comment:5 Changed 11 years ago by Becky Gibson

Resolution: fixed
Status: newclosed

fixed in [15950]

comment:6 Changed 7 years ago by bill

In [29966]:

Inline functions used only once, and remove "treeTests" wrapper around helper functions. The wrapper was of questionable value. Refs #8000.

comment:7 Changed 7 years ago by bill

In [29967]:

Group startup, runTest, tearDown functions together, refs #8000.

comment:8 Changed 7 years ago by bill

In [29968]:

Rearrange definitions of tests to be next to doh.register() calls, refs #8000.

comment:9 Changed 7 years ago by bill

In [30028]:

Combine tests for basic navigation (tab, arrows, home, and end keys, plus selection) into one section, in order to simplify test and to better check that tab stops work correctly in typical usage. Refs #8000.

comment:10 Changed 7 years ago by bill

In [30047]:

Catch errors during _setup(), refs #8000

comment:11 Changed 7 years ago by bill

In [30608]:

fix race conditions with test not waiting for TreeNodes to expand/collapse before setting aria roles, refs #8000

Note: See TracTickets for help on using tickets.