Gallery breaks if prototype.js is present

[tomagnew]

ThumbnailPicker? no longer scrolls if prototype.js is loaded. See attached test page (test_Gallery.html with prototype.js added).

Stepping through in firebug, smoothScroll seems to be called as usual. Could the problem be in fx?

I am running with Dojo 1.2 and Prototype 1.6.0.3.

[dante]

there is some magic going on in smoothScroll window detection, I would be willing to bet that's it. Is 1.6.0.3 the newest? will need to download and test.

[tomagnew]

You would win the bet! As you suggested, I traced the window detection logic inside fx/scroll.js, and indeed the problem is there.

Here is the offending code, at line 16:

var isWindow = dojo[(dojo.isIE ? "isObject" : "isFunction")](args["win"].scrollTo);

It appears to be detecting the presence of the "scrollTo" method to determine if the widget is a window. Unfortunately, prototype.js defines a scrollTo method under Element. When prototype is present, this method appears to exist, and smoothScroll thinks that arg is a window.

Is there a safer/more explicit test to determine if the arg is a window?

Also, I also found scrollTo methods defined in grid/_Grid.js and grid/_View.js. I suspect these have similar bugs.

What is the best way to fix this?

[dante]

heh. The best way to fix this is to not use Prototype ;) (this is why we don't extend native prototypes / builtins, wreaks all sorts of interoability havoc)

not sure how we can fix this, even feature detection would be fooled.

[Colin Snover]

This package is ​abandoned.