Opened 12 years ago
Closed 11 years ago
#7988 closed defect (fixed)
[patch] [cla] [ProgressBar] typeo in public API
| Reported by: | dante | Owned by: | Joseph Scheuhammer |
|---|---|---|---|
| Priority: | high | Milestone: | 1.3 |
| Component: | Dijit | Version: | 1.2.0 |
| Keywords: | Cc: | Adam Peller, Becky Gibson | |
| Blocked By: | Blocking: |
Description
In ProgressBar there is a potentially public api: this.inteterminateHighContrastImage that should probably be indeterminateHighContrastImage in both the template and js, but it counts as a public API change to correct ...
I suggest fixing in place. The reference is an attribute for the template's benefit, and the image it points to is a _private attribute. This seems a small correction.
Attachments (1)
Change History (8)
comment:1 Changed 12 years ago by
| Milestone: | tbd → 1.3 |
|---|
comment:2 Changed 12 years ago by
| Owner: | changed from Adam Peller to Becky Gibson |
|---|
comment:3 Changed 11 years ago by
| Owner: | changed from Becky Gibson to Joseph Scheuhammer |
|---|
minimally, just fix the typo. Can use a shorter name, as long as it's not abbreviated (style guide doesn't permit that)
Changed 11 years ago by
| Attachment: | 7988.patch added |
|---|
comment:5 Changed 11 years ago by
| Cc: | Adam Peller Becky Gibson added |
|---|
comment:6 Changed 11 years ago by
| Summary: | [ProgressBar] typeo in public API → [patch] [cla] [ProgressBar] typeo in public API |
|---|
comment:7 Changed 11 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
Note: See
TracTickets for help on using
tickets.
might not hurt to shorten the names while we're at it