Opened 11 years ago

Closed 11 years ago

#7988 closed defect (fixed)

[patch] [cla] [ProgressBar] typeo in public API

Reported by: dante Owned by: Joseph Scheuhammer
Priority: high Milestone: 1.3
Component: Dijit Version: 1.2.0
Keywords: Cc: Adam Peller, Becky Gibson
Blocked By: Blocking:

Description

In ProgressBar there is a potentially public api: this.inteterminateHighContrastImage that should probably be indeterminateHighContrastImage in both the template and js, but it counts as a public API change to correct ...

I suggest fixing in place. The reference is an attribute for the template's benefit, and the image it points to is a _private attribute. This seems a small correction.

Attachments (1)

7988.patch​ (1.0 KB) - added by Joseph Scheuhammer 11 years ago.

Download all attachments as: .zip

Change History (8)

comment:1 Changed 11 years ago by Adam Peller

Milestone: tbd → 1.3

comment:2 Changed 11 years ago by Adam Peller

Owner: changed from Adam Peller to Becky Gibson

might not hurt to shorten the names while we're at it

comment:3 Changed 11 years ago by Adam Peller

Owner: changed from Becky Gibson to Joseph Scheuhammer

minimally, just fix the typo. Can use a shorter name, as long as it's not abbreviated (style guide doesn't permit that)

comment:4 Changed 11 years ago by Joseph Scheuhammer

Adding patch, "7988.patch", that fixes the typo.

Changed 11 years ago by Joseph Scheuhammer

Attachment: 7988.patch​ added

comment:5 Changed 11 years ago by Joseph Scheuhammer

Cc: Adam Peller Becky Gibson added

comment:6 Changed 11 years ago by Joseph Scheuhammer

Summary: [ProgressBar] typeo in public API → [patch] [cla] [ProgressBar] typeo in public API

comment:7 Changed 11 years ago by Adam Peller

Resolution: → fixed
Status: new → closed

(In [16333]) Commit patch from clown to fix typo. Fixes #7988

Note: See TracTickets for help on using tickets.