Opened 12 years ago
Closed 12 years ago
#7983 closed task (fixed)
Dijit: ESC cancels out of edit, cancel dialogs, etc. and do nothing in std form controls
Reported by: | David Schwartz | Owned by: | Douglas Hays |
---|---|---|---|
Priority: | high | Milestone: | 1.3 |
Component: | Dijit - LnF | Version: | 1.2.0 |
Keywords: | ibm ESC | Cc: | |
Blocked By: | Blocking: |
Description
This originally came up in a discussion of InlineEditBox? but really addresses all of dijit. ESC should:
- Cancel out of edit mode for InlineEditBox?
- Cancel dialog boxes and
- Cancel pop-up controls such as DateTextBox?
- Have no other effects on form controls.
Attachments (1)
Change History (7)
comment:1 Changed 12 years ago by
Owner: | set to Douglas Hays |
---|
comment:3 Changed 12 years ago by
Maybe this can go into 1.3 since beta hasn't been cut yet. One design change that I'd like to propose is that a validation error tooltip popup on textboxes be closed on Esc and that the same Esc key event would not subsequently cancel an InlineEditBox? edit mode or a Dialog popup box.
comment:4 Changed 12 years ago by
Milestone: | 1.4 → 1.3 |
---|---|
Type: | defect → task |
Yup, sounds good to me. I didn't test the patch but I looked over the code fairly carefully and it all looks good to me.
comment:5 Changed 12 years ago by
From the originator:
"ESC is used to leave a temporary mode. A mode in this case is a state in which the effect of user actions varies from their standard effects. When in edit mode with in-line edit, the mode is obvious. Based on this definition, the tooltip display is not a mode in that it doesn't change the effect of user actions. ESC should have no effect on tooltips."
comment:6 Changed 12 years ago by
Resolution: | → fixed |
---|---|
Status: | new → closed |
(In [16530]) Fixes #7983 !strict. Removed Esc processing that calls undo(). Added InlineEditBox? test to test_Dialog.html to verify correct behavior.
Yes, we agreed on this.
I think this is just a question of removing the ESC catching code from the simple form controls (like TextBox). Perhaps need some supression code for IE's default behavior. The other stuff should be working already.