Opened 11 years ago

Closed 10 years ago

#7975 closed enhancement (fixed)

Legalize dojo.destroyElement()

Reported by: Eugene Lazutkin Owned by: dante
Priority: high Milestone: 1.3
Component: Core Version: 1.2.0
Keywords: Cc: Adam Peller, James Burke, Eugene Lazutkin, bill
Blocked By: Blocking:

Description

We already have very useful dojo._destroyElement(). Let's legalize it by aliasing it to dojo.destroyElement(). Variant: dojo.destroy().

The testing done by Neil Roberts shows that this function is still relevant on IE browsers.

Attachments (3)

dojo-destroy.patch​ (2.0 KB) - added by dante 10 years ago.
dojo namespace _destroyElement elimination
dijit-destroy.patch​ (8.0 KB) - added by dante 10 years ago.
dijit namespace _destroyElement elimination
dojox-destroy.patch​ (15.9 KB) - added by dante 10 years ago.
dojox namedspace _destroyElement elimination

Download all attachments as: .zip

Change History (14)

comment:1 Changed 11 years ago by Eugene Lazutkin

Relevant dojo-dev discussion: ​http://thread.gmane.org/gmane.comp.web.dojo.devel/9105.

comment:2 Changed 10 years ago by Eugene Lazutkin

Milestone: tbd → future
Owner: changed from anonymous to Eugene Lazutkin

Reassigning some core tickets to me as agreed with jburke.

comment:3 Changed 10 years ago by Eugene Lazutkin

Somehow #7802 has the patch for this ticket.

comment:4 Changed 10 years ago by dante

Milestone: future → 1.3
Owner: changed from Eugene Lazutkin to dante

added dojo.create and dojo.destroy in [16163]

Changed 10 years ago by dante

Attachment: dojo-destroy.patch​ added

dojo namespace _destroyElement elimination

Changed 10 years ago by dante

Attachment: dijit-destroy.patch​ added

dijit namespace _destroyElement elimination

Changed 10 years ago by dante

Attachment: dojox-destroy.patch​ added

dojox namedspace _destroyElement elimination

comment:5 Changed 10 years ago by dante

Cc: Adam Peller James Burke Eugene Lazutkin bill added

I've attached three patches to this ticket deprecating the use of dojo._createElement in each namespace. Dojo Core's few references definitely should go in trunk now. Dijit probably could, as few people use mixed Dijit + Base Dojo combinations (though there are probably some. dojo.destroy = dojo._destroyElement; is a solution there), but the question of DojoX patch made me hesitant. Applying the DojoX patch means every touched project is dependent on Dojo Base 1.3, and some project authors may not want that, though the same backwards-compat-alias applies in this case too, should users desiring mixing a "newer dojox project" with a "pre 1.3 dojo.js". comments?

comment:6 Changed 10 years ago by dante

(In [16178]) refs #7975 - make grid dep on Dojo 1.3 (destroy()) probably !strict

comment:7 Changed 10 years ago by dante

Priority: normal → high
Status: new → assigned

comment:8 Changed 10 years ago by dante

(In [16201]) refs #7975 - update to use dojo.destroy

comment:9 Changed 10 years ago by dante

(In [16203]) refs #7975 - more dojox stuff with +1 from author to make 1.3-dep for dojo.destroy !strict

comment:10 Changed 10 years ago by dante

(In [16219]) dojo.destroy change. refs #7975 - still a couple more before fixed.

comment:11 Changed 10 years ago by dante

Resolution: → fixed
Status: assigned → closed

(In [16246]) fixes #7975 - the last of the internal _destroyElement references. can deprecate for 2.0

Note: See TracTickets for help on using tickets.