Opened 12 years ago
Closed 12 years ago
#7975 closed enhancement (fixed)
Legalize dojo.destroyElement()
Reported by: | Eugene Lazutkin | Owned by: | dante |
---|---|---|---|
Priority: | high | Milestone: | 1.3 |
Component: | Core | Version: | 1.2.0 |
Keywords: | Cc: | Adam Peller, James Burke, Eugene Lazutkin, bill | |
Blocked By: | Blocking: |
Description
We already have very useful dojo._destroyElement(). Let's legalize it by aliasing it to dojo.destroyElement(). Variant: dojo.destroy().
The testing done by Neil Roberts shows that this function is still relevant on IE browsers.
Attachments (3)
Change History (14)
comment:1 Changed 12 years ago by
comment:2 Changed 12 years ago by
Milestone: | tbd → future |
---|---|
Owner: | changed from anonymous to Eugene Lazutkin |
Reassigning some core tickets to me as agreed with jburke.
comment:4 Changed 12 years ago by
Milestone: | future → 1.3 |
---|---|
Owner: | changed from Eugene Lazutkin to dante |
added dojo.create and dojo.destroy in [16163]
Changed 12 years ago by
Attachment: | dojo-destroy.patch added |
---|
dojo namespace _destroyElement elimination
Changed 12 years ago by
Attachment: | dijit-destroy.patch added |
---|
dijit namespace _destroyElement elimination
Changed 12 years ago by
Attachment: | dojox-destroy.patch added |
---|
dojox namedspace _destroyElement elimination
comment:5 Changed 12 years ago by
Cc: | Adam Peller James Burke Eugene Lazutkin bill added |
---|
I've attached three patches to this ticket deprecating the use of dojo._createElement in each namespace. Dojo Core's few references definitely should go in trunk now. Dijit probably could, as few people use mixed Dijit + Base Dojo combinations (though there are probably some. dojo.destroy = dojo._destroyElement;
is a solution there), but the question of DojoX patch made me hesitant. Applying the DojoX patch means every touched project is dependent on Dojo Base 1.3, and some project authors may not want that, though the same backwards-compat-alias applies in this case too, should users desiring mixing a "newer dojox project" with a "pre 1.3 dojo.js". comments?
comment:6 Changed 12 years ago by
comment:7 Changed 12 years ago by
Priority: | normal → high |
---|---|
Status: | new → assigned |
comment:9 Changed 12 years ago by
comment:10 Changed 12 years ago by
comment:11 Changed 12 years ago by
Resolution: | → fixed |
---|---|
Status: | assigned → closed |
Relevant dojo-dev discussion: http://thread.gmane.org/gmane.comp.web.dojo.devel/9105.