Opened 11 years ago

Closed 10 years ago

Last modified 10 years ago

#7974 closed enhancement (fixed)

Factor out a list of events from NodeList

Reported by: Eugene Lazutkin Owned by: Eugene Lazutkin
Priority: high Milestone: 1.4
Component: HTML Version: 1.2.0
Keywords: Cc:
Blocked By: Blocking:

Description

The NodeList code contains a list of DOM events, that can be (re)used in other places. Let's make it public. This is mentioned in #7802.

Change History (7)

comment:1 Changed 11 years ago by Eugene Lazutkin

Milestone: tbdfuture
Owner: changed from anonymous to Eugene Lazutkin

Reassigning some core tickets to me as agreed with jburke.

comment:2 Changed 11 years ago by Eugene Lazutkin

Component: CoreHTML

comment:3 Changed 10 years ago by Eugene Lazutkin

Resolution: fixed
Status: newclosed

(In [17954]) Making public a list of DOM events used in NodeList?, !strict, fixes #7974.

comment:4 Changed 10 years ago by Eugene Lazutkin

Milestone: future1.4

comment:5 Changed 10 years ago by James Burke

I wonder, does this need to be "events" or "_events"? Is it something we want as publicly visible property or just a "private" property we can use outside the NodeList? closure?

comment:6 Changed 10 years ago by Eugene Lazutkin

Hard to tell. I wanted to use it DojoX. It is required for any kind of DOM node wrappers. So I wanted to make it public. I don't expect that the list is going to change much, and exposing it seems harmless and do not appear to restrict us in any way.

comment:7 Changed 10 years ago by James Burke

OK, well with "events" I think there is higher expectation of documentation, both inline and on dojocampus. But I'm fine with it either way.

Note: See TracTickets for help on using tickets.