Opened 11 years ago

Closed 11 years ago

#7950 closed defect (fixed)

IE8: BorderContainer is broken

Reported by: Adam Peller Owned by: Adam Peller
Priority: high Milestone: 1.3
Component: Dijit Version: 1.2.0
Keywords: Cc:
Blocked By: Blocking:

Description

dojo.query in _setupChild is trying to find region on instantiated widgets Not sure how this ever worked. Replacing with a local hashmap to find the children. Perhaps there's a better way?

Change History (5)

comment:1 Changed 11 years ago by Adam Peller

Resolution: fixed
Status: newclosed

Fixed in [12522]

comment:2 Changed 11 years ago by Adam Peller

ok, that wasn't even close. Fixed in [15522]

comment:3 Changed 11 years ago by bill

Resolution: fixed
Status: closedreopened

That looks good. I see a few issues though with the _region hash though:

  1. I'm surprised that calling getChildren() from postCreate() works at all. Children aren't supposed to be setup until the startup() call
  2. addChild() presumably doesn't work because the new child isn't added to _region.

Looks like you should be inserting into the _region hash in _setupChild() not postCreate().

comment:4 Changed 11 years ago by Adam Peller

oops. we were already maintaining that info in _setupChild, so _regions wasn't needed. See [15658]

comment:5 Changed 11 years ago by Adam Peller

Resolution: fixed
Status: reopenedclosed
Note: See TracTickets for help on using tickets.