Opened 11 years ago

Closed 10 years ago

#7914 closed defect (fixed)

[patch] [ccla] grid: onRowClick should support keyboard via enter key or space key press

Reported by: Becky Gibson Owned by: Bryan Forbes
Priority: high Milestone: 1.3
Component: DojoX Grid Version: 1.2.0
Keywords: a11y Cc: Becky Gibson
Blocked By: Blocking:

Description

There is an onRowClick event handler to allow the user to add functionality to the click of a row. This is used in the mail demo - when a row is clicked in the inbox list, the associated mail text is displayed in the preview pane. There needs to be equivalent keyboard functionality for onRowClick. This is also related to navigation and selection - #7484, #7485, #7492

Attachments (2)

7914_7676.patch (1.6 KB) - added by Becky Gibson 10 years ago.
fixes both 7914 and #7676
7914.patch (679 bytes) - added by Becky Gibson 10 years ago.
fixes just 7914

Download all attachments as: .zip

Change History (9)

comment:1 Changed 10 years ago by Bryan Forbes

Milestone: tbd1.3

comment:2 Changed 10 years ago by Bryan Forbes

Milestone: 1.3future

comment:3 Changed 10 years ago by Becky Gibson

Summary: grid: onRowClick should support keyboard via enter key or space key press[patch] [ccla] grid: onRowClick should support keyboard via enter key or space key press

I modified the ENTER key handler to decorate the event and call onrowclick() if the cell has not enetered edit mode via the enter key press. Let the selection handlers run first. Needs a review.

I added two patches - one with just this fix and the other that also contains the fixe for #7676 as they both affect the onkey handler code.

Changed 10 years ago by Becky Gibson

Attachment: 7914_7676.patch added

fixes both 7914 and #7676

comment:4 Changed 10 years ago by Becky Gibson

updated patch to fix a bug when there is only on view (and thus focus.focusView is not found)

Changed 10 years ago by Becky Gibson

Attachment: 7914.patch added

fixes just 7914

comment:5 Changed 10 years ago by Becky Gibson

Milestone: future1.3

comment:6 Changed 10 years ago by Becky Gibson

Note that I didn't impement space key to invoke on row click as I had concerns about interference with selection. I can live with just enter key press to invoke onrowclick via that keyboard.

comment:7 Changed 10 years ago by Bryan Forbes

Resolution: fixed
Status: newclosed

(In [16816]) * Applied patches from Becky Gibson. (fixes #6989, fixes #7228, fixes #7676, fixes #7677, fixes #7914, fixes #7922, fixes #8696 !strict)

Note: See TracTickets for help on using tickets.