Opened 11 years ago

Closed 10 years ago

#7905 closed defect (wontfix)

dojo.style fontWeight

Reported by: Mike Wilcox Owned by: dante
Priority: high Milestone: tbd
Component: Core Version: 1.2beta
Keywords: style fontweight Cc:
Blocked By: Blocking:

Description

RE a fix to this ticket: make sure that dojo.style() returns "bold" and not 700 for font weight queries on IE. Refs #7480

This is only a partial fix. It works fine for IE, but Firefox also returns numbers. Specifically, font-weight:normal returns: 400. Numbers are also returned if "bolder" is used, which increments the numerical font weight by one.

I suggest the attached patch, which takes the number check out of the IE-only block and checks it for all browsers. It checks greater or less than 400, so all numbers will return either bold or normal. There's also the benefit that it is a few less characters.

Attachments (1)

html_fontweight.diff (1.0 KB) - added by Mike Wilcox 11 years ago.
fontWeight diff

Download all attachments as: .zip

Change History (3)

Changed 11 years ago by Mike Wilcox

Attachment: html_fontweight.diff added

fontWeight diff

comment:1 Changed 11 years ago by Tom Trenka

Owner: changed from phiggins to dante

comment:2 Changed 10 years ago by dante

Resolution: wontfix
Status: newclosed

i'm not sure this should be in base, as the overall complications and bloat involved in checking every possible edge case needs to be discussed. perhaps a comprehensive list of css properties and quirks could be extracted out of this and #7906 (dojox.fx.style attempts to create part of that list already) could benefit many, but a 'partial fix' here doesn't seem appropriate. marking wontfix for now, but feel free to expand on this and investigate full solution/map for supported browsers.

Note: See TracTickets for help on using tickets.