Opened 11 years ago

Closed 8 years ago

Last modified 8 years ago

#7879 closed task (fixed)

Document charting

Reported by: Adam Peller Owned by: Eugene Lazutkin
Priority: blocker Milestone: 1.8
Component: Charting Version: 1.2.0
Keywords: Cc: dylan, Tom Trenka
Blocked By: Blocking:

Description (last modified by Eugene Lazutkin)

Ok, we probably changed the rules on you, but to be beta now we need inline docs.

...and we need normal docs as well.

Attachments (1)

Tooltip.js.patch (4.6 KB) - added by Marcus Reimann 10 years ago.

Download all attachments as: .zip

Change History (22)

comment:1 Changed 11 years ago by Eugene Lazutkin

Status: newassigned
  1. Where are the rules published?
  2. Let's downgrade the project temporarily to be in the compliance with the rules.

comment:2 Changed 11 years ago by Adam Peller

for lack of a better place, it's in the Dojo book.

http://dojotoolkit.org/book/dojo-book-0-9/part-5-dojox-extensions-dojo-0

My bad for not making a pass through looking for this particular aspect when we changed the rules. Yeah, I dunno which is worse, downgrading a project or being out of compliance. I'd think we could get away with the latter in a transition phase if we make progress on docs. I'll leave the choice to you.

comment:3 Changed 11 years ago by Eugene Lazutkin

Milestone: tbdfuture
Priority: highhighest

comment:4 Changed 11 years ago by rdunklau

I would be glad to help on the charting documentation. How can i contact you elatzukin ? I have some questions about the chars and their bugs/(features? ;)).

Thanks.

comment:5 Changed 11 years ago by Eugene Lazutkin

@rdunklau: you can write email to eugene at this domain name.

comment:6 Changed 11 years ago by Eugene Lazutkin

Description: modified (diff)
Milestone: future1.3
Summary: charting needs inline docsDocument charting
Type: defecttask

comment:7 Changed 11 years ago by Eugene Lazutkin

Milestone: 1.3future

Moving open tickets to the future.

comment:8 Changed 10 years ago by Eugene Lazutkin

(In [21891]) Added test for the tension parameter, !strict, refs #7879.

comment:9 Changed 10 years ago by Tom Trenka

(In [21940]) Document the Theme. Refs #7879 !strict.

comment:10 Changed 10 years ago by Tom Trenka

(In [21941]) Document the defineColors method. Refs #7879 !strict.

comment:11 Changed 10 years ago by Tom Trenka

(In [21942]) Document the base axis and the common functions for axes. Refs #7879 !strict.

comment:12 Changed 10 years ago by Tom Trenka

(In [21943]) Document the base plot. Refs #7879 !strict.

comment:13 Changed 10 years ago by Tom Trenka

(In [21944]) Document the default plot. Refs #7879 !strict.

comment:14 Changed 10 years ago by Tom Trenka

(In [21945]) Document all of the plots in Charting. Refs #7879 !strict.

comment:15 Changed 10 years ago by Tom Trenka

(In [21946]) Document the actions for charting. Refs #7879 !strict.

comment:16 Changed 10 years ago by Tom Trenka

(In [21947]) Forgot a comma in the PieCtorArgs definition. Refs #7879 !strict.

comment:17 Changed 10 years ago by Tom Trenka

(In [21948]) Pull the two semi-colons after private function definitions so that the docparser doesn't break. Refs #7879 !strict.

Changed 10 years ago by Marcus Reimann

Attachment: Tooltip.js.patch added

comment:18 Changed 10 years ago by Marcus Reimann

Hi Tom,

I'm not sure if JSLint is a little bit to picky, but attached you will find a patch for dojox/charting/action2d/Tooltip.js with some changes regarding semicolon and "=== null" instead of "== null".

Regards, Marcus

comment:19 Changed 10 years ago by Marcus Reimann

Hi Tom,

please ignore my patch. I was wrong and I've read something about the Comma Operator in the meantime. A terrible syntax in my eyes, but maybe useful in this case.

Regards,

Marcus

comment:20 Changed 8 years ago by dylan

Cc: dylan,ttrenkadylan, ttrenka
Resolution: fixed
Status: assignedclosed

Closing this out, charting is documented. While not perfectly, it's a very old ticket.

comment:21 Changed 8 years ago by bill

Milestone: future1.8
Note: See TracTickets for help on using tickets.