Image Gallery toggleSlideshow() broken
DojoX's Image Gallery uses a SlideShow? for a portion of its behavior. Its toggleSlideshow() method is probably simply meant to call slideShow.toggleSlideShow(). Unfortunately, it calls the nonexistent slideShow.toggleSlideshow() instead. The obvious fix is to change the call to toggleSlideShow(); however, I think it makes more sense to change all the occurrences of "Slideshow" in Gallery.js to "SlideShow?" to make things more consistent. Unfortunately this latter fix would change Gallery's public toggleSlideshow() method resulting in a very minor API change, albeit to a method that's currently not working.
Change History (6)
Component: |
General →
Dojox
|
Owner: |
changed from anonymous to dante
|
Owner: |
changed from dante to sos
|
Milestone: |
tbd →
future
|
Owner: |
changed from sos to Shane O'Sullivan
|
Resolution: |
→ fixed
|
Status: |
new →
closed
|
shane - please peek at this and see if you can't come up with a patch, or whathaveyou.