Opened 11 years ago

Closed 11 years ago

Last modified 11 years ago

#7873 closed defect (fixed)

Image Gallery toggleSlideshow() broken

Reported by: Feneric Owned by: Shane O'Sullivan
Priority: high Milestone: 1.4
Component: Dojox Version: 1.2.0
Keywords: DojoX Image Gallery Cc:
Blocked By: Blocking:

Description

DojoX's Image Gallery uses a SlideShow? for a portion of its behavior. Its toggleSlideshow() method is probably simply meant to call slideShow.toggleSlideShow(). Unfortunately, it calls the nonexistent slideShow.toggleSlideshow() instead. The obvious fix is to change the call to toggleSlideShow(); however, I think it makes more sense to change all the occurrences of "Slideshow" in Gallery.js to "SlideShow?" to make things more consistent. Unfortunately this latter fix would change Gallery's public toggleSlideshow() method resulting in a very minor API change, albeit to a method that's currently not working.

Change History (6)

comment:1 Changed 11 years ago by Adam Peller

Component: General → Dojox
Owner: changed from anonymous to dante

comment:2 Changed 11 years ago by dante

Owner: changed from dante to sos

shane - please peek at this and see if you can't come up with a patch, or whathaveyou.

comment:3 Changed 11 years ago by dante

Milestone: tbd → future
Owner: changed from sos to Shane O'Sullivan

comment:4 Changed 11 years ago by Shane O'Sullivan

Fix for this checked in change set ​http://bugs.dojotoolkit.org/changeset/17957

I accidentally added the reference to #7843.

comment:5 Changed 11 years ago by Shane O'Sullivan

Resolution: → fixed
Status: new → closed

comment:6 Changed 11 years ago by Adam Peller

Milestone: future → 1.4
Note: See TracTickets for help on using tickets.