Opened 11 years ago

Closed 11 years ago

Last modified 10 years ago

#7867 closed defect (fixed)

dojox.form.FileUploader: allow djConfig path to uploader.swf?

Reported by: James Burke Owned by: Mike Wilcox
Priority: high Milestone: 1.3
Component: DojoX Form Version: 1.2.0
Keywords: Cc:
Blocked By: Blocking:

Description

I think there are issues trying to use the uploader.swf from a CDN location. There may be crossdomain.xml issues. Since it is unlikely the CDN will be configured with a proper crossdomain.xml file, it might be worth allowing the configuration of the swf location via:

FileUploader?._swfPath = dojo.config.FileUploaderSwf?
dojo.moduleUrl("dojox.form", "resources/uploader.swf")

Or something like that. Issue was raised in this thread: http://www.dojotoolkit.org/forum/dojox-dojox/dojox-support/cant-get-dojox-form-fileuploader-work-dojo-1-2-0-aol-cdn

Attachments (1)

CDN.zip (20.2 KB) - added by Mike Wilcox 11 years ago.
Test Case and Patch for CDN

Download all attachments as: .zip

Change History (7)

Changed 11 years ago by Mike Wilcox

Attachment: CDN.zip added

Test Case and Patch for CDN

comment:1 Changed 11 years ago by Mike Wilcox

I've attached a test case of getting the CDN to work with the FileUploader?.

Currently, as you said James, we need to rely upon a local SWF because of the crossdomain.xml required otherwise.

The attached isn't actually a patch - it's a temporary workaround. include the files/FileUploader.js in a script tag, then after the CDN loads, call doPatch (in dojo.addOnLoad), and the FileUploader? is overwritten. The new FileUploader? allows the usage of the included local SWF file. It's a new SWF, with the Security set to allow all domains.

comment:2 Changed 11 years ago by Mike Wilcox

Owner: changed from dante to Mike Wilcox

comment:3 Changed 11 years ago by Mike Wilcox

Resolution: fixed
Status: newclosed

commit 15927

FileUploader? now accepts a parameter for the SWF path, and will first look in: dojo.config.uploaderPath.

Note the SWF *has* to come from the same domain. Setting up security for it to work from our CDN is not realistic.

comment:4 Changed 11 years ago by Adam Peller

@jburke: let me know if you think this is critical enough for pushing to the CDNs in 1.2.3. We still haven't quite cut the release.

@mwilcox: do we have a place to document the new djConfig property?

comment:5 Changed 11 years ago by James Burke

peller: I"m a bit late getting through my mail: I do not think it needs to go in 1.2.3 :)

comment:6 Changed 10 years ago by Adam Peller

Milestone: tbd1.3

batch move of tickets marked 'tbd' fixed in the 1.3 timeframe

Note: See TracTickets for help on using tickets.