Spinner: use doh.robot to test keyboard a11y

[Joseph Scheuhammer]

Manually testing that dijit.form._Spinner is keyboard accessible, and that it implements the keystrokes as documented, is time consuming. Such testing should be automated.

Also, it would be useful to test whether spinner's required aria properties are properly set as the spinner is manipulated. These include the role (spinbutton) and aria-valuemin, aria-valuemax, and aria-valuenow properties.

[Joseph Scheuhammer]

The attached patch file, "7864.patch", provides unit tests for the aria role, valuemin, valuemax, and valuenow properties; and robot tests for the keystrokes documented for spinner (TAB focussing, arrow keys, PgUp, PgDn, Home, and End).

One test fails, namely, where the spinner's value is set to null (spinner.attr('value', null)). In that case, spinner.attr('value') returns NaN, but dijit.getWaiState(spinner, aria-valuenow) returns the empty string. That is, the value and the aria-valuenow do not match. This may be an issue with the ARIA spec in that it does not state what valuenow should be if the spinner has no value. My feeling is that the "value" and the "valuenow" should always match -- they should both be NaN, in this case.

[Joseph Scheuhammer]

• Merged tests from separate "test_a11y_Spinner.html" with existing "test_Spinner.html"; see attachment "7864a.patch".
• tests for ARIA role (spinbutton) and properties (valuemin, valuemax, and valuenow).
• robot tests for Tab focus/navigation for most of the spinners.
• robot tests of a11y keystrokes for all of the spinners (arrow keys, pgup, pgdn, home, and end).

Notes:

• tab navigation tests do not work in IE7. The focus listener attached with dojo.connect(spinner.focusNode, ...) does not fire in IE7. The focus listener is used to detect when focus moves to a spinner after a Tab or Shift+Tab keypress.
• keystroke tests do not work in IE7. The keypress listener attached via dojo.connect() does not fire in IE7. The keypress listener is used to acquire the new value after an a11y keypress.
• the nullAriaValueNow() test fails (see ticket #7866, and comment above).

[Joseph Scheuhammer]

Fix such that tab-focus tests and keystroke tests work in IE. Tested FF3/OSX and IE7/WinXP

[Becky Gibson]

fixed in changeset [15568] from clown (ATRC ccla on file)