Opened 11 years ago

Closed 11 years ago

#7858 closed defect (fixed)

[patch][ccla] dojo.animateProperty does not cancel on delay

Reported by: bbyron Owned by: dante
Priority: high Milestone: 1.3
Component: Core Version: 1.2.0
Keywords: animateProperty delay play stop Cc:
Blocked By: Blocking:

Description

If you call an animation with the play function and pass in a delay parameter, the stop call does not take this into account. Example:

// Calls an animation (myAnimation) to start after 1 second.
myAnimation.play(1000);
// This is supposed to cancel the animation before it starts
myAnimation.stop();

The above example should stop the animation from ever playing, but since the stop call does not cancel the thread, the animation still plays after the second delay.

I have attached a code example and a patch that does save and cancel the animation.

Attachments (3)

test_stopAnimatePropertyDelay.html (708 bytes) - added by bbyron 11 years ago.
dojo._base.fx.js.patch (1.6 KB) - added by bbyron 11 years ago.
fx.diff (6.9 KB) - added by dante 11 years ago.
updating this patch - same as patch on #8022

Download all attachments as: .zip

Change History (7)

Changed 11 years ago by bbyron

Changed 11 years ago by bbyron

Attachment: dojo._base.fx.js.patch added

comment:1 Changed 11 years ago by dante

Milestone: tbd1.3
Owner: changed from anonymous to dante

comment:2 Changed 11 years ago by dante

Status: newassigned
Summary: dojo.animateProperty does not cancel on delay[patch]]ccla] dojo.animateProperty does not cancel on delay

Changed 11 years ago by dante

Attachment: fx.diff added

updating this patch - same as patch on #8022

comment:3 Changed 11 years ago by dante

Summary: [patch]]ccla] dojo.animateProperty does not cancel on delay[patch][ccla] dojo.animateProperty does not cancel on delay

comment:4 Changed 11 years ago by dante

Resolution: fixed
Status: assignedclosed

fixed in [15846]. thanks bbyron!

Note: See TracTickets for help on using tickets.