Opened 11 years ago

Closed 11 years ago

#7852 closed defect (fixed)

var 'theRole' declared in global scope in _base/wai.js

Reported by: William Riley Owned by: Becky Gibson
Priority: high Milestone: 1.2.1
Component: Core Version: 1.2.0
Keywords: Cc:
Blocked By: Blocking:

Description

in /dijit/_base/wai.js on line 80, there's a variable called 'theRole' that's being declared in the global scope.

Attachments (1)

global.patch​ (498 bytes) - added by dante 11 years ago.
it doesn't seem to be used, either. attached is a small fix for review to ensure theRole isn't used as a stray elsewhere

Download all attachments as: .zip

Change History (6)

Changed 11 years ago by dante

Attachment: global.patch​ added

it doesn't seem to be used, either. attached is a small fix for review to ensure theRole isn't used as a stray elsewhere

comment:1 Changed 11 years ago by dante

Owner: changed from anonymous to Becky Gibson

comment:2 Changed 11 years ago by Adam Peller

Milestone: tbd → 1.2.1

marking for consideration in 1.2.1

comment:3 Changed 11 years ago by davidb

Patch looks good to me (my 2 cents)

comment:4 Changed 11 years ago by davidb

While we are at it, JSLint also suggests:

var needsA11y = (cs.borderTopColor==cs.borderRightColor)
(bkImg != null...

!= should be !== (when comparing against null)

comment:5 Changed 11 years ago by Adam Peller

Resolution: → fixed
Status: new → closed

fixed in trunk [15494]

fixed in 1.2 [15495]

Note: See TracTickets for help on using tickets.