Opened 11 years ago

Closed 10 years ago

Last modified 10 years ago

#7845 closed defect (fixed)

change isSafari to isWebkit to support Chrome

Reported by: James Burke Owned by: James Burke
Priority: high Milestone: 1.3
Component: General Version: 1.2.0
Keywords: Cc:
Blocked By: Blocking:

Description

Now that there is dojo.isWebKit, consider if it is better to use for these areas:

  • _base/event.js
  • _base/html.js
  • _base/lang.js
  • _base/query.js
  • _firebug/firebug.js
  • back.js
  • dnd/autoscroll.js
  • dnd/Manager.js
  • dnd/Mover.js
  • io/iframe.js

Change History (7)

comment:1 Changed 11 years ago by bill

Component: CoreGeneral
Summary: Dojo Core: check isSafari usechange isSafari to isWebkit to support Chrome

This ticket is being used for all of dojo, not just core. Adam has checked in a bunch of fixes for this, but there are still many references to isSafari. Fixes so far:

comment:2 Changed 11 years ago by James Burke

(In [16065]) Refs #7845, scrubbing dojo.isSafari use in Core, using isWebKit where appropriate. Have not done dojo.dnd internals though, and dojo._firebug had some isSafari references too, but not sure those need to change. \!strict

comment:3 Changed 11 years ago by Eugene Lazutkin

[16066]: dojo.dnd: switching from isSafari to isWebkit, refs #7845, !strict.

comment:4 Changed 11 years ago by Eugene Lazutkin

(In [16067]) dojo.dnd: typo fix: switching from isWebkit to isWebKit, refs #7845, !strict.

comment:5 Changed 11 years ago by Adam Peller

(In [16069]) revert isFunction() check for isWebKit. Unit test added in [15738]. Refs #7845

comment:6 Changed 10 years ago by James Burke

Resolution: fixed
Status: newclosed

Core has been scrubbed, closing this bug out. Cannot speak to dojox modules, but that works should be handled by individual tickets by the module owners.

comment:7 Changed 10 years ago by Adam Peller

(In [16546]) Change isSafari to isWebKit. Refs #7845 !strict

Note: See TracTickets for help on using tickets.